Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master sorcery by Ismael Luceno (ec486fc52b559dfb41e94437fb5fb8d2389d2382)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Sukneet Basuta <sukneet AT gmail.com>
  • To: "sm-commit AT lists.ibiblio.org" <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] GIT changes to master sorcery by Ismael Luceno (ec486fc52b559dfb41e94437fb5fb8d2389d2382)
  • Date: Mon, 12 Jan 2015 12:53:18 -0500

On Mon, Jan 12, 2015 at 8:55 AM, Ismael Luceno <ismael.luceno AT gmail.com> wrote:
On Mon, 12 Jan 2015 12:58:19 +0100
Remko van der Vossen <wich AT yuugen.jp> wrote:
> Besides that, who says that a downgrade is not a reasonable thing to
> do? If I was running on stable, switched to master, but then decided
> that the system is not workable for me and wanted to switch back. That
> situation would be unworkable with the updated version.

IMHO, it's not reasonable _default_ behavior. Grimoire-wide downgrading
should be implemented in some other way, something explicit.

I have to agree with Remko. While I have something similar implemented on my local sorcery, this should not be in the average user's sorcery. The default version should be whatever version is in the selected grimoire. If we downgrade something there is a good reason for it.

From a developer's point of view, I agree with you. Switching between branches can be annoying. But if a user switches branches, they should be running versions in the selected branch. I don't see why grimore-wide downgrading needs to implemented.

> Finally there may be very good reasons for
> downgrading a spell in the grimoire itself; there may be security
> issues with a new version, crashing issues, whatever. If we revert an
> update it is for good reason and the systems tracking the grimoire
> should follow suit.

If that's the case, SECURITY_PATCH would have been incremented...

That's not necessarily true.  There are plenty of cases we just revert a commit in master.




Archive powered by MHonArc 2.6.24.

Top of Page