Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master sorcery by Ismael Luceno (ec486fc52b559dfb41e94437fb5fb8d2389d2382)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Remko van der Vossen <wich AT yuugen.jp>
  • To: Ismael Luceno <ismael AT sourcemage.org>, sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master sorcery by Ismael Luceno (ec486fc52b559dfb41e94437fb5fb8d2389d2382)
  • Date: Mon, 12 Jan 2015 12:58:19 +0100

On Sun, Jan 04, 2015 at 01:16:35AM -0600, Ismael Luceno wrote:
> libqueue: Implement proper version comparison

I don't think I like this. version comparison is an incredibly fickle
thing. Furthermore, I don't think it has any place in queueing.

Version comparison is very much something that I would like to see
supported in sorcery. The reason however is not queueing, but proper
dependencies. Many times particular versions of spells need particular
versions of other spells, it would be very worthwhile if we could
express this properly in the dependencies.

Proper version comparison is however extremely difficult to do right,
version naming conventions vary enourmously among spells. A simple
lexographical ordering is never going to work. There will always be
examples where this will fail. Therefore we can only implement a default
in sorcery itself, but will need customizaibility within the spells
themselves with e.g. some optional version comparison function in the
spell.

Besides that, who says that a downgrade is not a reasonable thing to do?
If I was running on stable, switched to master, but then decided that
the system is not workable for me and wanted to switch back. That
situation would be unworkable with the updated version. Similarly, there
could be a new version of a spell in the grimoire which breaks some
things for me, so I make a local spell using an older version. The cast
however doesn't work so I need to force it for no good reason. Finally
there may be very good reasons for downgrading a spell in the grimoire
itself; there may be security issues with a new version, crashing
issues, whatever. If we revert an update it is for good reason and the
systems tracking the grimoire should follow suit.

I really believe that a simple not equals relation is the best solution
to the problem here.

Regards, Remko




Archive powered by MHonArc 2.6.24.

Top of Page