Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to devel-pyrobor2 sorcery by Bor Kraljič (6f47b4d7893056703a03c80a2019885411f03f5d)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Bor Kraljič <pyrobor AT ver.si>
  • To: Andraž 'ruskie' Levstik <ruskie AT codemages.net>
  • Cc: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to devel-pyrobor2 sorcery by Bor Kraljič (6f47b4d7893056703a03c80a2019885411f03f5d)
  • Date: Wed, 26 Oct 2011 09:13:05 +0200

On 21. of Oct 2011 12:26:02 Andraž 'ruskie' Levstik <ruskie AT codemages.net>
wrote:
> :2011-10-21T11:47:Bor Kraljič:
> > Anyway this change is just in MY devel branch of sorcery. So the change
> > will stay in this branch (at least for now). However main branch
> > (master) is up to Jaka. But thank you for expressing your opinion I am
> > sure Jaka will take your comment into consideration.
>
> Am aware of that.
Somewhere in hooks bug discusion[1] you mention that if you remove all hooks
sorcery should still run without a problem. This is not the case ATM because
cleanse is still using set_term_title. But most probably better solution
would
be modify cleanse to use hooks (xterm_title.hook).

>
> > So in your opinion copying set_term_title function into scripts that use
> > this function is the best way to go?
>
> Yes. Maybe have a libgurutools in guru-tools that scripts can rely on to
> have a stable API.

[1] http://bugs.sourcemage.org/show_bug.cgi?id=13938#c15




Archive powered by MHonArc 2.6.24.

Top of Page