Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to devel-pyrobor2 sorcery by Bor Kraljič (6f47b4d7893056703a03c80a2019885411f03f5d)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Bor Kraljič <pyrobor AT ver.si>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to devel-pyrobor2 sorcery by Bor Kraljič (6f47b4d7893056703a03c80a2019885411f03f5d)
  • Date: Fri, 21 Oct 2011 11:50:53 +0200

On 21. of Oct 2011 11:32:28 Andraž 'ruskie' Levstik <ruskie AT codemages.net>
wrote:
> :2011-10-21T11:30:Andraž 'ruskie' Levstik:

> > :2011-10-21T04:20:Bor Kraljič:
> > I don't agree with this change. It was moved FROM inside sorcery to
> > outside because it has nothing to do with the core sorcery
> > functionality.
Due to move of that function from libmisc to hooks cleanse in current git
repository complains that it missing [1]. That will probably go away with
adding init_hooks to all commands.

Anyway this change is just in MY devel branch of sorcery. So the change will
stay in this branch (at least for now). However main branch (master) is up to
Jaka. But thank you for expressing your opinion I am sure Jaka will take your
comment into consideration.

> Also guru-tools are external tools that often use non defined APIs for
> their work. As such it is expected behaviour that they break every so
> often.
So in your opinion copying set_term_title function into scripts that use this
function is the best way to go?


[1] http://www.sourcemage.org/issues/298

PS: resending mail to sm-commits




Archive powered by MHonArc 2.6.24.

Top of Page