sm-commit AT lists.ibiblio.org
Subject: Source Mage code commit list
List archive
Re: [SM-Commit] GIT changes to master grimoire by Ismael Luceno (1dae39b079e11622e568e6f47c0bc8b30b2bf277)
- From: Bor Kraljič <pyrobor AT ver.si>
- To: Ismael Luceno <ismael.luceno AT gmail.com>
- Cc: sm-commit AT lists.ibiblio.org
- Subject: Re: [SM-Commit] GIT changes to master grimoire by Ismael Luceno (1dae39b079e11622e568e6f47c0bc8b30b2bf277)
- Date: Sat, 17 Sep 2011 09:24:24 +0200
On 17. of Sep 2011 3:29:12 Ismael Luceno <ismael.luceno AT gmail.com> wrote:
> El Thu, 15 Sep 2011 10:34:02 +0200
> Bor Kraljič <pyrobor AT ver.si> escribió:
> <...>
>
> > > a/utils/flashrom/DETAIL b/utils/flashrom/DETAILS
> > > index 916ea2d..7868d42 100755
> > > --- a/utils/flashrom/DETAILS
> > > +++ b/utils/flashrom/DETAILS
> > > @@ -1,7 +1,12 @@
> > >
> > > SPELL=flashrom
> > >
> > > -if [[ ${FLASHROM_SCM} == "y" ]]
> > > +if [[ ${FLASHROM_BRANCH} == scm ]]
> > >
> > > then
> > >
> > > + if [[ $FLASHROM_AUTOUPDATE = y ]]
> > > + then
> > > + VERSION=$(date +%Y%m%d)
> > > + else
> > >
> > > VERSION=scm
> > >
> > > + fi
> > >
> > > SOURCE=${SPELL}-${VERSION}.tar.bz2
> > >
> > > SOURCE_URL[0]=svn://coreboot.org/flashrom/trunk:${SOURCE%.ta
> > > r.bz2}
> > >
> > > FORCE_DOWNLOAD=on
> >
> > That is not good. SOURCE for scm AUTOUPDATE shouldn't be
> > ${SPELL}-${VERSION}.tar.bz2. Because that it will re-download
> > *everything* from upstream on each update.
> >
> > We should use SOURCE=${SPELL}-scm.tar.bz2 for VERSION=$(date +%Y%m%d)
> > just like for VERSION=scm. That way only new changes are pulled down.
> >
> > Spell flashrom is just an example I noticed that you updated other
> > spells that way too.
> >
> > Regards, Bor
>
> Yep, fixed now. Sorry, missed that one.
>
> Thanks!
I mentioned that flashrom is just an example there are other spells with such
source. Spell *irssi* has the same problem. Others that you updated are OK I
think.
Regards, Bor
Attachment:
signature.asc
Description: This is a digitally signed message part.
-
[SM-Commit] GIT changes to master grimoire by Ismael Luceno (1dae39b079e11622e568e6f47c0bc8b30b2bf277),
Ismael Luceno, 09/15/2011
-
Re: [SM-Commit] GIT changes to master grimoire by Ismael Luceno (1dae39b079e11622e568e6f47c0bc8b30b2bf277),
Bor Kraljič, 09/15/2011
-
Re: [SM-Commit] GIT changes to master grimoire by Ismael Luceno (1dae39b079e11622e568e6f47c0bc8b30b2bf277),
Ismael Luceno, 09/17/2011
- Re: [SM-Commit] GIT changes to master grimoire by Ismael Luceno (1dae39b079e11622e568e6f47c0bc8b30b2bf277), Bor Kraljič, 09/17/2011
-
Re: [SM-Commit] GIT changes to master grimoire by Ismael Luceno (1dae39b079e11622e568e6f47c0bc8b30b2bf277),
Ismael Luceno, 09/17/2011
-
Re: [SM-Commit] GIT changes to master grimoire by Ismael Luceno (1dae39b079e11622e568e6f47c0bc8b30b2bf277),
Bor Kraljič, 09/15/2011
Archive powered by MHonArc 2.6.24.