Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Ismael Luceno (1dae39b079e11622e568e6f47c0bc8b30b2bf277)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Ismael Luceno <ismael.luceno AT gmail.com>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Ismael Luceno (1dae39b079e11622e568e6f47c0bc8b30b2bf277)
  • Date: Sat, 17 Sep 2011 03:29:12 -0300

El Thu, 15 Sep 2011 10:34:02 +0200
Bor Kraljič <pyrobor AT ver.si> escribió:
<...>
> > a/utils/flashrom/DETAIL b/utils/flashrom/DETAILS
> > index 916ea2d..7868d42 100755
> > --- a/utils/flashrom/DETAILS
> > +++ b/utils/flashrom/DETAILS
> > @@ -1,7 +1,12 @@
> > SPELL=flashrom
> > -if [[ ${FLASHROM_SCM} == "y" ]]
> > +if [[ ${FLASHROM_BRANCH} == scm ]]
> > then
> > + if [[ $FLASHROM_AUTOUPDATE = y ]]
> > + then
> > + VERSION=$(date +%Y%m%d)
> > + else
> > VERSION=scm
> > + fi
> > SOURCE=${SPELL}-${VERSION}.tar.bz2
> > SOURCE_URL[0]=svn://coreboot.org/flashrom/trunk:${SOURCE%.tar.bz2}
> > FORCE_DOWNLOAD=on
> That is not good. SOURCE for scm AUTOUPDATE shouldn't be
> ${SPELL}-${VERSION}.tar.bz2. Because that it will re-download
> *everything* from upstream on each update.
>
> We should use SOURCE=${SPELL}-scm.tar.bz2 for VERSION=$(date +%Y%m%d)
> just like for VERSION=scm. That way only new changes are pulled down.
>
> Spell flashrom is just an example I noticed that you updated other
> spells that way too.
>
> Regards, Bor

Yep, fixed now. Sorry, missed that one.

Thanks!

Attachment: signature.asc
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page