Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Vlad Glagolev (078aedbc624091ae85d8c2991ffde888348befcc)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Eric Sandall <eric AT sandall.us>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Vlad Glagolev (078aedbc624091ae85d8c2991ffde888348befcc)
  • Date: Sat, 30 Jan 2010 09:44:43 -0800

On Mon, 25 Jan 2010 02:41:30 +0100
Ladislav Hagara <ladislav.hagara AT unob.cz> wrote:

>
> >>> It was my commit, and since i maintain the spell, i didn't want
> >>> to make the merges. It was just easier.
> >>>
> >>>
> >> Easier is not equal to correct in this case. When several people
> >> were updating the gnome spells without first talking to Robin, he
> >> didn't revert all their commits and pretend that he was the only
> >> one doing the work. He merged his work with what others had pushed
> >> up. That's for an entire section, not one spell, and involved a
> >> lot more changes (real conflicts, not just adding his work on top
> >> of others).
> >
> > weird Vlad...
>
>
> So who will fix the HISTORY file?
> Imho, Pol should me mentioned there.
> What are the opinions of our PL and GL?

As another Lead, I'd say the HISTORY entry should be added back.
Generally it's whomever commits *and* pushes first that gets to keep
their entry, everyone else will have to merge the conflicts and accept
upstream (whatever is pushed to our central servers) as the master
copy. If someone's commit is less correct than yours, you may revert
their change and use your commit.

All IMO, of course. :)

-sandalle

--
Eric Sandall | Source Mage GNU/Linux Developer
eric AT sandall.us PGP: 0xA8EFDD61 | http://www.sourcemage.org/
http://eric.sandall.us/ | http://counter.li.org/ #196285

Attachment: signature.asc
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page