Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master z-rejected grimoire by George Sherwood (e8e851c9f4255c6f54037dd045154a6c387f02e6)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Julien ROZO <julien AT rozo.org>
  • To: George Sherwood <pilot AT beernabeer.com>
  • Cc: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master z-rejected grimoire by George Sherwood (e8e851c9f4255c6f54037dd045154a6c387f02e6)
  • Date: Wed, 10 Sep 2008 18:55:54 +0200

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

George Sherwood a écrit :
> On Wed, 10 Sep 2008 09:04:11 +0200
> Julien ROZO <julien AT rozo.org> wrote:
>>
>> What problem did you exactly had ?
>>
>>
>> I strongly suggest this commit to be reverted as FILENAME declaration
>> is less generic than previously.
>>
>
> It failed for me, as the variable never got set and PRE_BUILD failed.
> I think this was due to there being two different files with almost the
> same name. There was openoffice.org3.0-freedesktop-menus-3.0-9350 and
> openoffice.org3.0-freedesktop-menus-3.0-9347 in the same directory.
> Tried this twice with the same failure, not sure what would be
> different with our setups. Are you installing language other than
> english?

Thanks George for pointing out this problem. I checked more accurately
the x86 package, and the openoffice.org3.0-*-menus-3.0-*.noarch.rpm
exists in two versions, including an obsolete one : 9350 is the latest
build, while 9347 is the oldest and does not exist in x86_64 package.

> I tried multiples time and always had the same error from PRE_BUILD.
> Understand this is not generic enough, but it needs to work.

I suggest we add in DETAILS a variable to handle the last digits,
something like :

BUILD_VERSION=9350


What do you, and other mages, think of it ?
It is heavier than nothing to update at each version bump, but at least
it's declared near VERSION so one will (I hope !) think of update it
while updating the spell.
Moreover it can more or less handle upstream packaging problem.
And it seems cleaner to me than having to change it in another script
than DETAILS.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQEcBAEBAgAGBQJIx/waAAoJEJuXOITO/v5teB0H/izMkL7sa9dHs3gkGwjNA+CE
w7G8c39ArvqTJhL4A+VCSjyrSJM2nw3v9De3giYvBKbn9PC8ZGuxUtNswCLRg9Gw
zGUpHzBbQ50eG9fvXKZMbFAIBJErXj40l2PMNMnjrjYByZieI7XrAV9uBHh7r9I8
5gCU4BE4TLPDgCYYVjwVjkGpvNii/Kwhkre1cHllv97wPsNY1ANIuejKpfOseebE
u/I3b7G+QN83Cmx/q0fmUh0Qj5urydTLPKyoGIzw80/PgrzlLTleiZQ4qls2A9q3
aa6uCM6esrhSrJECs7kePueL5+e70zF61ixGsJaxka/CcWcJexCmYCi+2G9BvfQ=
=pi2u
-----END PGP SIGNATURE-----




Archive powered by MHonArc 2.6.24.

Top of Page