Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master z-rejected grimoire by George Sherwood (e8e851c9f4255c6f54037dd045154a6c387f02e6)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: George Sherwood <pilot AT beernabeer.com>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master z-rejected grimoire by George Sherwood (e8e851c9f4255c6f54037dd045154a6c387f02e6)
  • Date: Wed, 10 Sep 2008 07:08:51 -0500

On Wed, 10 Sep 2008 09:04:11 +0200
Julien ROZO <julien AT rozo.org> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> George Sherwood a écrit :
> > GIT changes to master z-rejected grimoire by George Sherwood
> > <gsherwood AT sourcemage.org>:
> >
> > z-editors/openoffice3-bin/HISTORY | 3 +++
> > z-editors/openoffice3-bin/PRE_BUILD | 2 +-
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > New commits:
> > commit e8e851c9f4255c6f54037dd045154a6c387f02e6
> > Author: George Sherwood <gsherwood AT sourcemage.org>
> > Commit: George Sherwood <gsherwood AT sourcemage.org>
> >
> > openoffice3-bin: Quick and dirty fix to extract the icon files.
> > It will need to be made more generic, but doesn't work as it.
> >
> >
> > message "${MESSAGE_COLOR}Extracting icons ${DEFAULT_COLOR}" &&
> > -FILENAME="openoffice.org${VERSION%.*}*-freedesktop-menus-${VERSION%.*}*"
> > &&
> > +FILENAME="openoffice.org${VERSION%.*}*-freedesktop-menus-3.0-9350"
> > &&
>
>
> it works with
> FILENAME="openoffice.org${VERSION%.*}*-freedesktop-menus-${VERSION%.*}*",
> I've tested it again just to be sure : RPM is unpacked, then gz file
> is gunzipped, and finally cpio file is extracted. Moreover, install
> log shows icons files copied to $INSTALL_ROOT/usr/share/icons/
>
>
> What problem did you exactly had ?
>
>
> I strongly suggest this commit to be reverted as FILENAME declaration
> is less generic than previously.
>

It failed for me, as the variable never got set and PRE_BUILD failed.
I think this was due to there being two different files with almost the
same name. There was openoffice.org3.0-freedesktop-menus-3.0-9350 and
openoffice.org3.0-freedesktop-menus-3.0-9347 in the same directory.
Tried this twice with the same failure, not sure what would be
different with our setups. Are you installing language other than
english?

I tried multiples time and always had the same error from PRE_BUILD.
Understand this is not generic enough, but it needs to work.

George Sherwood

Attachment: signature.asc
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page