Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Vlad Glagolev (b1af30fb141069e135784a8a3e7c6c95c36a4318)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jaka Kranjc <lynx AT mages.ath.cx>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Vlad Glagolev (b1af30fb141069e135784a8a3e7c6c95c36a4318)
  • Date: Tue, 22 Jan 2008 23:51:11 +0100

On Tuesday 22 of January 2008 23:41:51 Ladislav Hagara wrote:
> > GIT changes to master grimoire by Vlad Glagolev <stealth AT sourcemage.org>:
> >
> > net/net-tools/HISTORY | 3 +++
> > net/net-tools/init.d/network | 2 +-
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > New commits:
> > commit b1af30fb141069e135784a8a3e7c6c95c36a4318
> > Author: Vlad Glagolev <stealth AT sourcemage.org>
> > Commit: Vlad Glagolev <stealth AT sourcemage.org>
> >
> > net-tools: fixed a weird bug in network init.d script -- [DEVICE] was
> > useless, when you try `telinit run network restart wlan0' -- before it
> > would restart all network devices you have in /etc/sysconfig/network, now
> > -- it just works properly :)
> >
> > diff --git a/net/net-tools/HISTORY b/net/net-tools/HISTORY
> > index 7a11807..69e9113 100644
> > --- a/net/net-tools/HISTORY
> > +++ b/net/net-tools/HISTORY
> > @@ -1,3 +1,6 @@
> > +2008-01-23 Vlad Glagolev <stealth AT sourcemage.org>
> > + * init.d/network: fixed a weird bug ([DEVICE] was useless, now it
> > works) +
> > 2007-09-05 David Brown <dmlb2000 AT gmail.com>
> > * DETAILS: patchlevel++
> >
> > diff --git a/net/net-tools/init.d/network b/net/net-tools/init.d/network
> > index 10cad56..bdfc2b2 100755
> > --- a/net/net-tools/init.d/network
> > +++ b/net/net-tools/init.d/network
> > @@ -19,7 +19,7 @@ netdevdir=/etc/sysconfig/network
> > # this provides you with the ability to start/stop/check status on
> > # one or more cards if you so desire.
> >
> > -if [ $# -le 1 ]; then
> > +if [ "$#" -le 1 ]; then
> > devices="$(ls $netdevdir | grep dev$ | cut -d. -f1)"
> > else
> > devices="$(builtin echo $@ | sed s/$1//)"
>
> Seems strange for me. Just trying it and I can't see the difference.
> "telinit run network status eth0" versus "telinit run network status"
> works OK without your change.
> $# must be always 1 or more, no needs "$#".
> Am I missing something?
It can be 0 too, but I agree that this is wierd. From experiments, I can't
find a difference either.

#!/bin/bash
[ $# -eq "$#" ]
echo $?

00000000000000000000
--
We cannot command nature except by obeying her. --Sir Francis Bacon
Have a sourcerous day! www.sourcemage.org

Attachment: signature.asc
Description: This is a digitally signed message part.




Archive powered by MHonArc 2.6.24.

Top of Page