sm-commit AT lists.ibiblio.org
Subject: Source Mage code commit list
List archive
Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (9034e037296a7633f78543836b7e409db5cf61c2)
- From: Treeve Jelbert <treeve AT scarlet.be>
- To: sm-commit AT lists.ibiblio.org
- Subject: Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (9034e037296a7633f78543836b7e409db5cf61c2)
- Date: Fri, 11 Jan 2008 21:35:25 +0100
On Friday 11 January 2008 21:18:46 Jaka Kranjc wrote:
> First, thanks for bringing us KDE4 this quickly! :)
>
> On Friday 11 of January 2008 21:09:38 Treeve Jelbert wrote:
> > TOOLS) [[ $QT_TOOLS == "-make" ]] && return 0;;
> > + QT3) [[ $QT_QT3 == "-no-qt3support" ]] && return 0;;
>
> Shouldn't this check if it is equal to -qt3support? PRE_SUB_DEPENDS should
> return 0 if the subdependency is met. You later request something that
> would fail this check.
>
fixed
> > diff --git a/x11-toolkits/qt4/SUB_DEPENDS b/x11-toolkits/qt4/SUB_DEPENDS
> > index 99404b6..fee3daa 100755
> > --- a/x11-toolkits/qt4/SUB_DEPENDS
> > ;;
> > +QT3) if [[ $QT_QT3 == "-no-qt3support" ]];then
> > + echo "Qt3 support requested, forcing rebuild." &&
> > + QT_QT3="-qt3support"
> > + ;;
> > *) echo unknown sub-depends!!! ; return 1 ;;
> > esac
--
Regards, Treeve
Attachment:
signature.asc
Description: This is a digitally signed message part.
-
[SM-Commit] GIT changes to master grimoire by Treeve Jelbert (9034e037296a7633f78543836b7e409db5cf61c2),
Treeve Jelbert, 01/11/2008
-
Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (9034e037296a7633f78543836b7e409db5cf61c2),
Jaka Kranjc, 01/11/2008
- Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (9034e037296a7633f78543836b7e409db5cf61c2), Treeve Jelbert, 01/11/2008
-
Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (9034e037296a7633f78543836b7e409db5cf61c2),
Jaka Kranjc, 01/11/2008
Archive powered by MHonArc 2.6.24.