Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (9034e037296a7633f78543836b7e409db5cf61c2)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jaka Kranjc <lynx AT mages.ath.cx>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (9034e037296a7633f78543836b7e409db5cf61c2)
  • Date: Fri, 11 Jan 2008 21:18:46 +0100

First, thanks for bringing us KDE4 this quickly! :)

On Friday 11 of January 2008 21:09:38 Treeve Jelbert wrote:
> TOOLS) [[ $QT_TOOLS == "-make" ]] && return 0;;
> + QT3) [[ $QT_QT3 == "-no-qt3support" ]] && return 0;;
Shouldn't this check if it is equal to -qt3support? PRE_SUB_DEPENDS should
return 0 if the subdependency is met. You later request something that would
fail this check.

> diff --git a/x11-toolkits/qt4/SUB_DEPENDS b/x11-toolkits/qt4/SUB_DEPENDS
> index 99404b6..fee3daa 100755
> --- a/x11-toolkits/qt4/SUB_DEPENDS
> ;;
> +QT3) if [[ $QT_QT3 == "-no-qt3support" ]];then
> + echo "Qt3 support requested, forcing rebuild." &&
> + QT_QT3="-qt3support"
> + ;;
> *) echo unknown sub-depends!!! ; return 1 ;;
> esac



--
We cannot command nature except by obeying her. --Sir Francis Bacon
Have a sourcerous day! www.sourcemage.org

Attachment: signature.asc
Description: This is a digitally signed message part.




Archive powered by MHonArc 2.6.24.

Top of Page