Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Colin Phoul Childs (c19e8f17d9024051b9f1aa46831f357f9a3dd3c4)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Eric Sandall <eric AT sandall.us>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Colin Phoul Childs (c19e8f17d9024051b9f1aa46831f357f9a3dd3c4)
  • Date: Tue, 15 May 2007 06:53:02 -0700

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andraž 'ruskie' Levstik wrote:
<snip>
>> diff --git a/audio-players/nyello/PREPARE b/audio-players/nyello/PREPARE
>> new file mode 100755
>> index 0000000..e5c7289
>> --- /dev/null
>> +++ b/audio-players/nyello/PREPARE
>> @@ -0,0 +1,9 @@
>> +config_query NYELLO_GIT "Use latest git code?" n &&
>> +
>> +if [[ "$NYELLO_GIT" == "y" ]]; then
>> + config_query NYELLO_GIT_AUTOUPDATE \
>> + "Update on every system-update?" n
>> + else
>> + persistent_add NYELLO_GIT_AUTOUPDATE &&
>> + NYELLO_GIT_AUTOUPDATE="n"
>> +fi
>
> You don't need persistent_add ALL config_* functions have
> persistent variables. Also this else is unnecessary. It defaults to
> n so it doesn't need any extra funky things.
<snip>

I told him to do this, so that's my fault. ;) You are correct, Andraž.

- -sandalle

- --
Eric Sandall | Source Mage GNU/Linux Developer
eric AT sandall.us PGP: 0xA8EFDD61 | http://www.sourcemage.org/
http://eric.sandall.us/ | http://counter.li.org/ #196285
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGSbs+HXt9dKjv3WERAk47AJ9JRVltpTWQTDVdUcox6arBsE37fQCeI9HC
pRVRM4hdY0q/b2ncWEvcjcQ=
=szeZ
-----END PGP SIGNATURE-----




Archive powered by MHonArc 2.6.24.

Top of Page