Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Colin Phoul Childs (c19e8f17d9024051b9f1aa46831f357f9a3dd3c4)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: "Andraž 'ruskie' Levstik" <ruskie AT mages.ath.cx>
  • To: <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Colin Phoul Childs (c19e8f17d9024051b9f1aa46831f357f9a3dd3c4)
  • Date: Tue, 15 May 2007 09:55:09 +0200

On 05:06:27 2007-05-15 Colin Phoul Childs <scm AT sourcemage.org> wrote:

The commit message is better though try starting it with the spellname
instead of DETAILS etc...

> --- a/audio-players/nyello/DEPENDS
> +++ b/audio-players/nyello/DEPENDS
> @@ -1,4 +1,6 @@
> -depends xmms2 &&
> +if [[ "$NYELLO_GIT" == "y" ]]; then
> +depends boost
> +fi
> depends readline &&
> -depends ncurses &&
> -sub_depends xmms2 BOOST
> +depends ncurses &&
> +depends xmms2

You're still missing the sub_depends xmms2 BOOST

if it needed it before it still needs it now. This is a c++ client so
xmms2 needs to be built with boost to provide xmms2client++
The direct boost dependency probably also needs a subdependency on
some parts of boost as well. So check what it needs and compare that with
the SUB_DEPENDS file in the boost spell and
depends boost SOME_BOOST_SUB_DEPENDS

> diff --git a/audio-players/nyello/DETAILS b/audio-players/nyello/DETAILS
> index 393f98a..9d0467e 100755
> --- a/audio-players/nyello/DETAILS
> +++ b/audio-players/nyello/DETAILS
> @@ -1,9 +1,21 @@
> SPELL=nyello
> - VERSION=0.5.0
> + if [[ "$NYELLO_GIT"=="y" ]]; then
> + if [[ "$NYELLO_GIT_AUTOUPDATE"=="y" ]]; then
> + VERSION=$(date +%Y%m%d)
> + else
> + VERSION=git
> + fi
> + SOURCE=$SPELL-git.tar.bz2
> + SOURCE_URL[0]=git://git.xmms.se/xmms2/nyello:nyello-git
> + SOURCE_IGNORE=volatile
> + SOURCE_DIRECTORY="${BUILD_DIRECTORY}/${SPELL}-git"

Missing FORCE_DOWNLOAD=on

> diff --git a/audio-players/nyello/HISTORY b/audio-players/nyello/HISTORY
> index e94e13a..86c85da 100644
> --- a/audio-players/nyello/HISTORY
> +++ b/audio-players/nyello/HISTORY
> @@ -1,3 +1,7 @@
> +2007-05-14 Colin "Phoul" Childs <phoul AT sourcemage.org>
> + * DETAILS, DEPENDS, PRE_BUILD: Spell now supports using the git
> repo to + compile nyello
> +

Try to be a bit more verbose in HISTORY entries. For example:
2007-05-14 Colin "Phoul" Childs <phoul AT sourcemage.org>
* DETAILS: Added support for git options
* DEPENDS: added/removed some depends
.
.
.

and such :)

> 2007-05-10 Colin Childs <phoul AT sourcemage.org>
> * DETAILS, DEPENDS, HISTORY: created spell
> 2007-05-10 Colin Childs <phoul AT sourcemage.org>
> diff --git a/audio-players/nyello/PREPARE b/audio-players/nyello/PREPARE
> new file mode 100755
> index 0000000..e5c7289
> --- /dev/null
> +++ b/audio-players/nyello/PREPARE
> @@ -0,0 +1,9 @@
> +config_query NYELLO_GIT "Use latest git code?" n &&
> +
> +if [[ "$NYELLO_GIT" == "y" ]]; then
> + config_query NYELLO_GIT_AUTOUPDATE \
> + "Update on every system-update?" n
> + else
> + persistent_add NYELLO_GIT_AUTOUPDATE &&
> + NYELLO_GIT_AUTOUPDATE="n"
> +fi

You don't need persistent_add ALL config_* functions have
persistent variables. Also this else is unnecessary. It defaults to
n so it doesn't need any extra funky things.

> diff --git a/audio-players/nyello/PRE_BUILD
> b/audio-players/nyello/PRE_BUILD new file mode 100755
> index 0000000..63262dc
> --- /dev/null
> +++ b/audio-players/nyello/PRE_BUILD
> @@ -0,0 +1,6 @@
> +default_pre_build &&
> +
> +if [ "$NYELLO_GIT" == "y" ]; then
> + cd $SOURCE_DIRECTORY
> + NOCONFIGURE=ON ./autogen.sh
> +fi

Use [[ ]] instead of [ ] iuso benchmarked this and [[ ]] was faster.


--
Andraž "ruskie" Levstik
Source Mage GNU/Linux Games grimoire guru
Geek/Hacker/Tinker

Hacker FAQ: http://www.plethora.net/%7eseebs/faqs/hacker.html
Be sure brain is in gear before engaging mouth.

Key id = F4C1F89C
Key fingerprint = 6FF2 8F20 4C9D DB36 B5B6 F134 884D 72CC F4C1 F89C





Archive powered by MHonArc 2.6.24.

Top of Page