Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Andra ž Levstik (8f45882dc4e2f0fe6e71e2fa6b5926daf6af61 77)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jaka Kranjc <lynx AT mages.ath.cx>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Andra ž Levstik (8f45882dc4e2f0fe6e71e2fa6b5926daf6af61 77)
  • Date: Fri, 20 Apr 2007 23:07:42 +0200

On Friday 20 of April 2007 22:56:46 Andraž 'ruskie' Levstik wrote:
> > > + if [[ -f ${TRACK_ROOT}/usr/share/GNUstep/Makefiles/GNUstep.sh ]]
> > > + then
> > > + . ${TRACK_ROOT}/usr/share/GNUstep/Makefiles/GNUstep.sh
> > > + fi
> >
> > Are you sure this ${TRACK_ROOT} usage is correct? It looks like it
> > should be INSTALL_ROOT to me.
> > Also, the last fi needs && or the function isn't chained properly.
>
> I'm still confused it needs to source it to work and it should be from
> where it sohuld be run afaik...
It should be INSTALL_ROOT.

Check Andrew's sm-commit mail from 23.01.07 03:11, it is very informative and
readable.

> > > +++ b/ChangeLog
> > > @@ -1,3 +1,8 @@
> > > +2007-04-20 Andraž "ruskie" Levstik <ruskie AT mages.ath.cx>
> > > + * gnustep-apps/FUNCTIONS: fixups
> > > + * gnustep-libs/FUNCTIONS: fixups
> >
> > Please be more verbose next time, "fixups" doesn't relay much (if
> > anything).
>
> Well I did the changes earlier and more or less forgot what I did before
> commiting...
*cough* you forgot with the second commit too? :P
"forgot some things" is not really an improvement.

--
We cannot command nature except by obeying her. --Sir Francis Bacon
Have a sourcerous day! www.sourcemage.org

Attachment: pgpJzGWO2fwDJ.pgp
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page