Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Andra ž Levstik (8f45882dc4e2f0fe6e71e2fa6b5926daf6af61 77)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: "Andraž 'ruskie' Levstik" <ruskie AT mages.ath.cx>
  • To: <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Andra ž Levstik (8f45882dc4e2f0fe6e71e2fa6b5926daf6af61 77)
  • Date: Fri, 20 Apr 2007 22:56:46 +0200

On 22:42:49 2007-04-20 Jaka Kranjc <lynx AT mages.ath.cx> wrote:
> first of all - thanks for giving this long forgotten section some
> attention!
>
> > + if [[ -f ${TRACK_ROOT}/usr/share/GNUstep/Makefiles/GNUstep.sh ]]
> > + then
> > + . ${TRACK_ROOT}/usr/share/GNUstep/Makefiles/GNUstep.sh
> > + fi
> Are you sure this ${TRACK_ROOT} usage is correct? It looks like it
> should be INSTALL_ROOT to me.
> Also, the last fi needs && or the function isn't chained properly.
>

I'm still confused it needs to source it to work and it should be from
where it sohuld be run afaik...

> > + if [[ -x ./configure ]]
> > + then
> > + real_default_build
> > + else
> > + make $@
> > + fi
> > }
> I noticed the previous function had some special doc handling - is that
> redundant now? I didn't see any spell changes to that effect (from the
> few I checked), but perhaps it is just some even older bitrot.
>

I removed the doc handling for now until I figure out a good common
denominator for them all and figure out better functions for it.

I'm not done with this sections yet...

> > + real_default_post_install
> > + if [[ -x /usr/bin/make_services ]]; then
> > + message "Running make_services"
> > + /usr/bin/make_services
> > + fi
> > }
> These two /usr/bin/ma* could use some INSTALL_ROOT too.
> Also, real_default_post_install needs && or the function wouldn't fail
> as it should sometimes.
>

Well I'm still confused about it... I'll take suggestions

> > +++ b/ChangeLog
> > @@ -1,3 +1,8 @@
> > +2007-04-20 Andraž "ruskie" Levstik <ruskie AT mages.ath.cx>
> > + * gnustep-apps/FUNCTIONS: fixups
> > + * gnustep-libs/FUNCTIONS: fixups
> Please be more verbose next time, "fixups" doesn't relay much (if
> anything).
>

Well I did the changes earlier and more or less forgot what I did before
commiting...

--
Andraž "ruskie" Levstik
Source Mage GNU/Linux Games grimoire guru
Geek/Hacker/Tinker

Hacker FAQ: http://www.plethora.net/%7eseebs/faqs/hacker.html
Be sure brain is in gear before engaging mouth.

Key id = F4C1F89C
Key fingerprint = 6FF2 8F20 4C9D DB36 B5B6 F134 884D 72CC F4C1 F89C





Archive powered by MHonArc 2.6.24.

Top of Page