Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Martin Spitzbarth (8a6fd4dd34c447855db2d69aac3b70d203f27f36)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jeremy Blosser <jblosser-smgl AT firinn.org>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Martin Spitzbarth (8a6fd4dd34c447855db2d69aac3b70d203f27f36)
  • Date: Tue, 17 Apr 2007 10:49:53 -0500

On Apr 17, Martin Spitzbarth [m.spitzbarth AT gmx.de] wrote:
> The problem for the last one is more of a cosmetic nature.
> =====compile.log of at-3.1.10 without my patch=====
> <snip>
> parsetime.y: In function 'parsetime':
> parsetime.y:510: warning: implicit declaration of function 'panic'
> <snip>
> =====
>
> The warning comes from
> =====parsetime.y lines 149-151=====
> if (exectime < currtime)
> panic("refusing to create job destined in the past");
> return exectime;
> =====
>
> I found the file "panic.h" in the sourcedirectory, that defined
> =====part of panic.h=====
> void
> #ifdef HAVE_ATTRIBUTE_NORETURN
> __attribute__((noreturn))
> #endif
> panic(char *a);
> =====
>
> I then added #include "panic.h" to parsetime.y and saved the diff as
> patch (3) from above.
>
> The spell works without that patch, so if you find it cleaner to not
> use it, I will be happy to remove it.

I don't think we usually consider warnings worth patching for. I know it
seems trivial to do, but the more patches we add ourselves, the more
difficult it becomes for users to tell exactly what is going on, and other
things tend to creep in.

Attachment: pgpef4f86nJQJ.pgp
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page