Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Martin Spitzbarth (8a6fd4dd34c447855db2d69aac3b70d203f27f36)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Martin Spitzbarth <m.spitzbarth AT gmx.de>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Martin Spitzbarth (8a6fd4dd34c447855db2d69aac3b70d203f27f36)
  • Date: Tue, 17 Apr 2007 17:05:49 +0200

On Tue, 17 Apr 2007 09:16:09 -0500
Jeremy Blosser <jblosser-smgl AT firinn.org> wrote:

> On Apr 17, Martin Spitzbarth [scm AT sourcemage.org] wrote:
> > + * at.patch: removed patch for 3.1.8, which is in upstream
> > now,
> > + added patch to avoid an implicit declaration warning.
>
> Where did this patch come from?

I'm not sure which patch you mean, but there are a total of three
patches involved in my change:

(1) at_3.1.8-10.2.diff.gz got downloaded as SOURCE2. I have removed
this one as the new version is 3.1.10
(2) at.patch from the grimoire directory. This patch added missing ";"
in parsetime.y. These ";" are already present in version 3.1.10, so
I have removed this file, to replace it with number (3)
(3) at.patch written by myself from scratch

The problem for the last one is more of a cosmetic nature.
=====compile.log of at-3.1.10 without my patch=====
<snip>
parsetime.y: In function 'parsetime':
parsetime.y:510: warning: implicit declaration of function 'panic'
<snip>
=====

The warning comes from
=====parsetime.y lines 149-151=====
if (exectime < currtime)
panic("refusing to create job destined in the past");
return exectime;
=====

I found the file "panic.h" in the sourcedirectory, that defined
=====part of panic.h=====
void
#ifdef HAVE_ATTRIBUTE_NORETURN
__attribute__((noreturn))
#endif
panic(char *a);
=====

I then added #include "panic.h" to parsetime.y and saved the diff as
patch (3) from above.

The spell works without that patch, so if you find it cleaner to not
use it, I will be happy to remove it.

Attachment: signature.asc
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page