Source Mage code commit list

[Jeremy Blosser <jblosser-smgl AT firinn.org>]

On Mar 31, Thomas Orgis [thomas-forum AT orgis.org] wrote:
> Am Tue, 27 Mar 2007 11:23:18 -0500
> schrieb Jeremy Blosser <jblosser-smgl AT firinn.org>: 
> 
> > >  install_config_file etc/limits       $INSTALL_ROOT/etc/limits       &&
> > >  install_config_file etc/login.access $INSTALL_ROOT/etc/login.access &&
> > >  install_config_file etc/login.defs   $INSTALL_ROOT/etc/login.defs   &&
> > > -
> > > +sed -i -e 's,^HOME=.*$,HOME='"$SHADOW_HOME"',' -e 
> > > 's,GROUP=1000,GROUP=users,' etc/useradd &&
> > 
> > This is the wrong way to do this; man useradd, look for '-D'.  This may
> > need to go in FINAL too.
> 
> I do not understand, can you tell me to what way you are referring?
> 
> man useradd:
> 
> When invoked without the -D option, the useradd command creates
> a new user account using the values specified on the command line and
> the default values from the system. Depending on command line options,
> the useradd command will update system files and may also create the
> new user's home directory and copy initial files.

Look further down:

   Changing the default values
       When invoked with the -D option, useradd will either display the
       current default values, or update the default values from the
       command line.  The valid options are

       -b HOME_DIR
              The initial path prefix for a new user's home directory. The
              user's name will be affixed to the end of HOME_DIR to create
              the new directory name if the -d option is not used when
              creating a new account.

> > Also, I am skeptical we want to change this to a named group instead of 
> > the
> > gid.  Upstream uses the gid; we shouldn't change it just because we think
> > we're smarter than them.  Maybe a local admin has renamed his users group
> > but still expects to use the same gid, or something.  It's the admin's 
> > job,
> > not ours.
> 
> Actually, I don't like this whole config mess at all... I just though
> I'd solve a problem with placing GROUP=users since virtually every box
> has a users group but the gid differs (100, 500, 1000 ...).
> At last, it's a user editable config file. perhaps we should just let.
> ppl. edit it. and drop the queries.
> Why did I introduce them again?

Well, because upstream was stupid and changed the default to something no
one uses.  I'd personally love to just override that but FHS says nothing
about where $HOME is, so we can't.  Some user may want it that stupid
place.

> Apart from the debatable parts of how to handle the useradd defaults
> (wich don't work as intended anyway), can we agree on these lines being
> in INSTALL:
> 
> echo "install:" > etc/Makefile &&
> echo "install:" > etc/pam.d/Makefile &&
> install_config_file etc/useradd $INSTALL_ROOT/etc/default/useradd &&
> 
> Because without them, shadow _always_ overwrites the config files on
> make install, which is ultraplusungood.
> We can deal with the users group and any default config stuff later.
> The bug fixed by these lines should be gating, where the workability of
> the default config has the workaround of simply fixing the config.

I don't have a problem with that part of the change, no.

Attachment: pgp7QiTlg2YVK.pgp
Description: PGP signature