Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to devel-shadow grimoire by Thomas Orgis (6161d6d9a4b27fd85b61331ed2e70928fcf7af92)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jeremy Blosser <jblosser-smgl AT firinn.org>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to devel-shadow grimoire by Thomas Orgis (6161d6d9a4b27fd85b61331ed2e70928fcf7af92)
  • Date: Tue, 27 Mar 2007 11:23:44 -0500

On Mar 27, Jeremy Blosser [jblosser AT firinn.org] wrote:
> > +local old_home=$(grep '^HOME=' $INSTALL_ROOT/etc/default/useradd
> > 2>/dev/null | sed 's/HOME=//') &&
> > +if [[ -n "$old_home" ]]; then
> > + default_home=$old_home
> > +fi &&
> > +config_query_string SHADOW_HOME "base directory for user homes:"
> > "$default_home" &&
>
> Maybe:
> "Base directory for user home directories (null to accept upstream
> default):"
>
> And it is entirely likely we should only ask the question and/or modify the
> config file it this is the first install (if the config file didn't exist
> when the cast started). I doubt it's good to modify the config file on a
> later upgrade if the admin changed it in the meantime.

To clarify, I know you're picking up the existing value before the query,
so we wouldn't be changing it... still not sure it's the best approach.

Attachment: pgpzQFZqD8Mt2.pgp
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page