Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] PERFORCE change 78002 by Sergey A. Lipnevich for review

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: "Jeremy Blosser (emrys)" <jblosser-smgl AT firinn.org>
  • To: "Sergey A.Lipnevich" <sergey AT sourcemage.org>
  • Cc: duane_malcolm <d.malcolm AT auckland.ac.nz>, Unet <unet AT sourcemage.org>, Gareth Clay <gareth AT caffeinefuelled.co.uk>, Eric Sandall <eric AT sandall.us>, Pol Vinogradov <vin.public AT gmail.com>, SM-Commit Daemon <sm-commit AT lists.ibiblio.org>, Andrew Stitt <a AT t.armory.com>, Arjan Bouter <abouter AT sourcemage.org>, vladimir_marek <vlmarek AT volny.cz>, Ladislav Hagara <ladislav.hagara AT unob.cz>, Maurizio Boriani <baux AT member.fsf.org>, Ethan Grammatikidis <eekee AT eekee.is-a-geek.org>
  • Subject: Re: [SM-Commit] PERFORCE change 78002 by Sergey A. Lipnevich for review
  • Date: Wed, 19 Apr 2006 11:05:00 -0500

On Apr 19, Perforce Review Daemon [p4review AT smee.org] wrote:
> Change 78002 by sergey_lipnevich@laptop on 2006/04/19 05:53:12
>
> Initialize LVM stuff before mounting root

This doesn't work. LVM fails because /proc isn't there when it tries to
scan. Based on my experience and the data in bug 9177 it'll also fail when
it doesn't have a r/w /etc.

I assume you're using / LVM with an initrd, so maybe that changes what's
available at that point, but it definitely doesn't work on a system that
has non-LVM /.

Please revert this at least in test and see bug 9177. If something isn't
working for you with what was there before you changed this, comment on the
bug and/or put a WIP in devel and we'll get it sorted out.

Thanks.

> Affected files ...
>
> ... //sgl/grimoires/devel/smgl/init.d/init.d/mountall.sh#12 edit
> ... //sgl/grimoires/devel/smgl/init.d/init.d/mountroot.sh#2 edit
>
> Differences ...
>
> ==== //sgl/grimoires/devel/smgl/init.d/init.d/mountall.sh#12 (xtext) ====
>
> @@ -58,13 +58,6 @@
> mount -a -t /proc
> evaluate_retval
>
> - if optional_executable /sbin/vgscan && optional_executable
> /sbin/vgchange ; then
> - echo -n "Scanning for and initializing all available LVM volume
> groups..."
> - /sbin/vgscan --ignorelockingfailure --mknodes &&
> - /sbin/vgchange -ay --ignorelockingfailure
> - evaluate_retval
> - fi
> -
> checkfs
>
> if optional_executable /sbin/swapon ; then
>
> ==== //sgl/grimoires/devel/smgl/init.d/init.d/mountroot.sh#2 (xtext) ====
>
> @@ -51,6 +51,16 @@
> raidstart --all
> fi
>
> + #
> + # Enable logical volumes for LVM and create device nodes
> + #
> + if optional_executable /sbin/vgscan && optional_executable
> /sbin/vgchange ; then
> + echo -n "Scanning for and initializing all available LVM volume
> groups..."
> + /sbin/vgscan --ignorelockingfailure --mknodes &&
> + /sbin/vgchange -ay --ignorelockingfailure
> + evaluate_retval
> + fi
> +
> echo "Mounting root file system read only..."
> mount -n -o remount,ro /
> evaluate_retval || exit 1
> _______________________________________________
> SM-Commit mailing list
> SM-Commit AT lists.ibiblio.org
> http://lists.ibiblio.org/mailman/listinfo/sm-commit

Attachment: pgpdFQxAGbNLp.pgp
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page