Skip to Content.
Sympa Menu

freetds - Re: [freetds] Reintegrating years of local FreeTDS changes

freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Chronological Thread  
  • From: Sebastien FLAESCH <sf AT 4js.com>
  • To: freetds AT lists.ibiblio.org
  • Subject: Re: [freetds] Reintegrating years of local FreeTDS changes
  • Date: Wed, 27 Jun 2018 11:37:00 +0200

Thanks for the link!

FYI:

...

data.c: In function 'tds_sybblob_get':
data.c:1585:10: warning: unused variable 'serialization_type'
[-Wunused-variable]
uint8_t serialization_type = tds_get_byte(tds);
^
...

bulk.c: In function 'tds_bcp_send_record':
bulk.c:622:23: warning: 'bitpos' may be used uninitialized in this function
[-Wmaybe-uninitialized]
rowbuffer[bitpos] |= 256 >> bitleft;
^
bulk.c:582:19: note: 'bitpos' was declared here
int bitleft = 0, bitpos;
^
...

dblib.c: In function 'copy_data_to_host_var':
dblib.c:7462:6: warning: unused variable 'i' [-Wunused-variable]
int i, len;
^
...

defncopy.c: In function 'get_login':
defncopy.c:670:6: warning: variable 'fdomain' set but not used
[-Wunused-but-set-variable]
int fdomain = TRUE;
^
...



$ g++ --version
g++ (Debian 4.9.2-10+deb8u1) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


Seb

On 06/26/2018 03:31 PM, Ucko, Aaron (NIH/NLM/NCBI) [E] wrote:
https://github.com/ucko/freetds

The ncbi-merge-request-1pre1 branch contains my full set of changes;
ncbi-merge-request-1 (aka master) leaves out one roughly in the middle that
changes the semantics of truncation, as discussed elsewhere in this thread.

Thanks!

-- Aaron Ucko <ucko at ncbi>, NCBI C++ Toolkit core development group

-----Original Message-----
From: Sebastien FLAESCH [mailto:sf AT 4js.com]
Sent: Tuesday, June 26, 2018 03:25
To: freetds AT lists.ibiblio.org
Subject: Re: [freetds] Reintegrating years of local FreeTDS changes

Hi all,

If you give me the Github link where I can download the sources, I can
recompile FreeTDS with all these changes and run or test suite with it.

Just let me know when it's stable enough to be tested.

Seb

On 06/23/2018 12:22 AM, Frediano Ziglio wrote:
Yes,
agreed with GitHub.

I though I already replied, apparently not.

Frediano


2018-06-21 22:02 GMT+01:00 Christos Zoulas <christos AT zoulas.com>:
On Jun 7, 12:12pm, freetds AT lists.ibiblio.org ("Ucko, Aaron \(NIH/NLM/NCBI\) \[E\]
via FreeTDS") wrote:
-- Subject: [freetds] Reintegrating years of local FreeTDS changes

| How would you like me to proceed? Should I send the patches here, or
| put them online through a GitHub fork? In the latter case, should I
| proceed to issue a formal pull request?

I am not Freddy, but I think that github sounds like the right way to
proceed. Thanks for the offer!

christos
_______________________________________________
FreeTDS mailing list
FreeTDS AT lists.ibiblio.org
https://lists.ibiblio.org/mailman/listinfo/freetds
_______________________________________________
FreeTDS mailing list
FreeTDS AT lists.ibiblio.org
https://lists.ibiblio.org/mailman/listinfo/freetds


_______________________________________________
FreeTDS mailing list
FreeTDS AT lists.ibiblio.org
https://lists.ibiblio.org/mailman/listinfo/freetds
_______________________________________________
FreeTDS mailing list
FreeTDS AT lists.ibiblio.org
https://lists.ibiblio.org/mailman/listinfo/freetds






Archive powered by MHonArc 2.6.24.

Top of Page