freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Re: [freetds] One failing unit test (iconv_read) on git master on OS X

From: Frediano Ziglio <freddy77 AT gmail.com>
To: FreeTDS Development Group <freetds AT lists.ibiblio.org>
Subject: Re: [freetds] One failing unit test (iconv_read) on git master on OS X
Date: Mon, 16 Sep 2013 08:44:33 +0100

2013/9/15 Marc Abramowitz <marca AT surveymonkey.com>:
> On 9/15/13 11:24 AM, "Marc Abramowitz" <marca AT surveymonkey.com> wrote:
>
>>So perhaps there's only 1024 bytes of space in the output buffer? I'll try
>>to dig in...
>
> Interesting data pointŠ If I make the following change, then it makes the
> iconv_read test pass (although it makes a few other tests fail and one
> hangs):
>
> https://gist.github.com/msabramo/6574246
>

I would call it workaround!

>
>
>
>
> So it appears that it has something to do with it not allocating a big
> enough buffer to not passing the right size.
>

No, libTDS is expected to handle it and reallocate the buffer as
needed. The function is expected to handle whatever file length so
it's not always possible to understand the right size in advance.

Frediano

[freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/14/2013
- Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Frediano Ziglio, 09/14/2013
  - Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/14/2013
- Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/14/2013
  - Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Frediano Ziglio, 09/15/2013
    - Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/15/2013
      - Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/15/2013
        
        Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/15/2013
        
        Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/15/2013
        
        Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Frediano Ziglio, 09/16/2013
        Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/16/2013
        Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/16/2013
        Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/16/2013
        Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/16/2013
        Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Frediano Ziglio, 09/16/2013
        Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/16/2013
        Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/18/2013
        Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Frediano Ziglio, 09/28/2013
        Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Frediano Ziglio, 09/29/2013
        Re: [freetds] One failing unit test (iconv_read) on git master on OS X, Marc Abramowitz, 09/30/2013