freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Re: [freetds] [PATCH bcp.c:_bcp_read_hostfile] don't trim trailing spaces when all spaces

From: "Craig A. Berry" <craigberry AT mac.com>
To: FreeTDS Development Group <freetds AT lists.ibiblio.org>
Subject: Re: [freetds] [PATCH bcp.c:_bcp_read_hostfile] don't trim trailing spaces when all spaces
Date: Tue, 20 Dec 2005 08:07:04 -0600

At 9:49 AM +0100 12/20/05, ZIGLIO, Frediano, VF-IT wrote:
> >
>> > From: Craig A. Berry
>> > Sent: Sunday, December 18, 2005 11:38 PM
>> >
>> > When bulking in character data, we currently trim trailing spaces,
>> > which in general seems like the right thing to do with one
>> exception.
>> > The exception is when a field is all spaces; I don't think we should
>> > trim those to nothing because then we end up inserting nulls in
> > > what may or may not be nullable fields.

>well, current rtrim implementation should handle correctly this case.

Good catch. I noticed the problem with 0.63 and submitted the patch
against the current snapshot without noticing that it's no longer
necessary. Ignore this one.
--
________________________________________
Craig A. Berry
mailto:craigberry AT mac.com

"... getting out of a sonnet is much more
difficult than getting in."
Brad Leithauser

Re: [freetds] [PATCH bcp.c:_bcp_read_hostfile] don't trim trailingspaces when all spaces, ZIGLIO, Frediano, VF-IT, 12/20/2005
- Re: [freetds] [PATCH bcp.c:_bcp_read_hostfile] don't trim trailing spaces when all spaces, Craig A. Berry, 12/20/2005