FreeTDS Development Group

["ZIGLIO, Frediano, VF-IT" <Frediano.Ziglio AT vodafone.com>]

> 
> Craig A. Berry wrote:
> > --- include/replacements.h;-0   Fri Jul  8 03:22:52 2005
> > +++ include/replacements.h      Sun Dec 18 16:13:06 2005
> > @@ -53,8 +53,8 @@
> >   char *strtok_r(char *str, const char *sep, char **lasts);
> >   #endif /* !HAVE_STRTOK_R */
> > 
> > -#if !HAVE_READPASSPHRASE
> > -# include <../src/replacements/readpassphrase.h>
> > +#ifndef HAVE_READPASSPHRASE
> > +# include "readpassphrase.h"
> >   #else
> >   # include <readpassphrase.h>
> >   #endif
> > [end of patch]
> > 
> > and then add whatever -I directives are necessary to make 
> the include
> > file findable. (The easy way to do the latter, of course, 
> would be to
> > simply move it from src/replacments to include/).
> > 
> > Does this make sense?
> 
> Hi Craig, 
> 
> At first blush, yes.  
> 
> I'm a little puzzled why the tree information is a problem.  In Unix
> environments, you'd have a hard time getting the build to work if you
> disturb the relationship between include/ and src/.  
> 
> Moving the replacement code to include/ is a big deal because 
> it affects
> CVS.  I could look at ways to have the autotools copy the 
> replacement code
> to include/replacements/ at build time.  Then the source would say 
> 
>       # include "replacements/readpassphrase.h"
> 
> which is at least intuitive.  
> 

IMHO I would prefer a cp/cvs add new/cvs remove old/cvs commit instead.
Or perhaps another option is to add src to include path and use #include
<replacements/readpassphrase.h>. However I don't understand the reason
to change this include, just to quote original message

> The other issue is that it seems to me
> 
> # include <../src/replacements/readpassphrase.h>
> 
> has far too much information hard-coded about where the include file
is 
> found and what directory I happen to be in when I'm compiling.

specially "... it that it seems ..." why "it seems" and not "it is" ??
And also "has too much information hard-coded" ... well, it the include
works I don't see any problems... header is "private" (not installed) so
if FreeTDS compile is not a problem.

freddy77