FreeTDS Development Group

["Lowden, James K" <LowdenJK AT bernstein.com>]

> From: Thompson, Bill D (London)
> Sent: Thursday, July 07, 2005 6:40 AM
> 
> in src/tds/query.c - function tds_put_n_as_ucs2() we use a function
> "alloca" this is not supported in my C compiler - is it gnu only
> ? I've replaced with malloc().

Argh!  I should have checked.  You're right, it's nonstandard.  It's
available in many forms, though: a gcc built-in, and in the public
domain:

http://www.opensource.apple.com/darwinsource/WWDC2004/gcc_legacy-939/lib
iberty/alloca.c

However, we're using alloca(3) in *one* place (as you know) and in a
very limited way.  malloc/free will do the job, of course, and so would
declaring char tmp_out[1024] on the stack.  We could assert at runtime
that the UCS-2 string would never be more than that; right now it's
never more than about 160 bytes.  

--jkl


-----------------------------------------
The information contained in this transmission may contain privileged and
confidential information and is intended only for the use of the person(s) 
named
above. If you are not the intended recipient, or an employee or agent 
responsible
for delivering this message to the intended recipient, any review, 
dissemination,
distribution or duplication of this communication is strictly prohibited. If 
you are
not the intended recipient, please contact the sender immediately by reply 
e-mail
and destroy all copies of the original message. Please note that we do not 
accept
account orders and/or instructions by e-mail, and therefore will not be 
responsible
for carrying out such orders and/or instructions.  If you, as the intended 
recipient
of this message, the purpose of which is to inform and update our clients, 
prospects
and consultants of developments relating to our services and products, would 
not
like to receive further e-mail correspondence from the sender, please "reply" 
to the
sender indicating your wishes.  In the U.S.: 1345 Avenue of the Americas, New 
York,
NY 10105.