Skip to Content.
Sympa Menu

freetds - Re: [freetds] [PATCH] VMS build update

freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Chronological Thread  
  • From: Brian Bruns <brian.bruns AT gmail.com>
  • To: FreeTDS Development Group <freetds AT lists.ibiblio.org>
  • Subject: Re: [freetds] [PATCH] VMS build update
  • Date: Sat, 6 Nov 2004 19:05:20 -0500

On Sat, 6 Nov 2004 17:09:38 -0500, James K. Lowden
<jklowden AT schemamania.org> wrote:
>
> Hi Craig,
>
> - if (freopen(options.input_filename, "r", stdin) < 0) {
> + if ((int)freopen(options.input_filename, "r", stdin) < 0) {
>
> Could I change all these to:
>
> if (freopen(options.input_filename, "r", stdin) < (FILE*)0) {
>
> I think that's more honest. BTW, does "< NULL" work better?
>
> Similarly,
>
> - if (options.verbose < 0) {
> + if ((int)options.verbose < 0) {
>
> oughta be
>
> if (options.verbose < (FILE*)0) {

Yuck, wouldn't NULL be better? I realize NULL == 0, however it is
convention to use NULL when dealing with pointers.

>
> I'd prefer these unless you can convince me otherwise or your compiler
> isn't satisfied.
>
> Thanks for the patch.
>
> Regards,
>
> --jkl




Archive powered by MHonArc 2.6.24.

Top of Page