FreeTDS Development Group

[Brian Bruns <brian.bruns AT gmail.com>]

On Sat, 6 Nov 2004 17:09:38 -0500, James K. Lowden
<jklowden AT schemamania.org> wrote:
> 
> Hi Craig,
> 
> - if (freopen(options.input_filename, "r", stdin) < 0) {
> + if ((int)freopen(options.input_filename, "r", stdin) < 0) {
> 
> Could I change all these to:
> 
> if (freopen(options.input_filename, "r", stdin) < (FILE*)0) {
> 
> I think that's more honest.  BTW, does "< NULL" work better?
> 
> Similarly,
> 
> - if (options.verbose < 0) {
> + if ((int)options.verbose < 0) {
> 
> oughta be
> 
> if (options.verbose < (FILE*)0) {

Yuck, wouldn't NULL be better?  I realize NULL == 0, however it is
convention to  use NULL when dealing with pointers.

> 
> I'd prefer these unless you can convince me otherwise or your compiler
> isn't satisfied.
> 
> Thanks for the patch.
> 
> Regards,
> 
> --jkl