Skip to Content.
Sympa Menu

freetds - Re: [freetds] [PATCH] VMS build update

freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Chronological Thread  
  • From: "James K. Lowden" <jklowden AT schemamania.org>
  • To: FreeTDS Development Group <freetds AT lists.ibiblio.org>
  • Subject: Re: [freetds] [PATCH] VMS build update
  • Date: Sat, 6 Nov 2004 17:09:38 -0500

"Craig A. Berry" <craigberry AT mac.com> wrote:
> The attached patch against last night's snapshot gets it building
> cleanly again on VMS. The bulk of it is just building new files
> introduced since the last time I updated the VMS-specific build
> procedures.
>
> There are a couple of other little nits, too: some casting in bsqldb.c
> and defncopy.c to quiet my picky compiler, and a small hack in
> src/tds/config.c to allow the successful location of SYBASE/interfaces
> on VMS.

Hi Craig,

- if (freopen(options.input_filename, "r", stdin) < 0) {
+ if ((int)freopen(options.input_filename, "r", stdin) < 0) {

Could I change all these to:

if (freopen(options.input_filename, "r", stdin) < (FILE*)0) {

I think that's more honest. BTW, does "< NULL" work better?

Similarly,

- if (options.verbose < 0) {
+ if ((int)options.verbose < 0) {

oughta be

if (options.verbose < (FILE*)0) {

I'd prefer these unless you can convince me otherwise or your compiler
isn't satisfied.

Thanks for the patch.

Regards,

--jkl




Archive powered by MHonArc 2.6.24.

Top of Page