FreeTDS Development Group

[Alex Kiesel <alex.kiesel AT document-root.de>]

On Sun, 2004-01-11 at 06:58, James K. Lowden wrote:
> Alex, thank you for the patch.  
> 
> Cancel and timeout handling is some of the trickiest logic in FreeTDS, at
> least in my estimation.  I cannot both include it in 0.62 *and* release
> 0.62 today.  It's a question of delaying the release or excluding the
> patch.  Issuing the release is more than simply making sure the unit tests
> all pass, after all.  

> I branched the code on Saturday, and am working on the release notes and
> announcements.  I think the safest thing to do, at this stage in the game,
> is to apply your patch to the trunk (not 0.62).  We could include your
> patch (and message) as a separate file in the release, to be applied at
> the user's discretion.  I'm open to suggestions on that score.  
> 
> I think there will be other ramifications to your patch, simple as it is. 
>   Certainly, error handling is rickety, and there is some interest in
> fixing query timeouts.  And it may well turn out that this area sees some
> substantial change, anyway, in 0.63. 
> 
> That's my PHB answer.  If more knowledgeable people tell me we should hold
> up and include this -- and make the other changes it implies or uncovers
> -- in 0.62, then OK, I yield to them.  It will mean a two week delay,
> however; I cannot promise the Release Engineering team will be available
> again until then.  They have something like 12 hours to express their
> opinions.  

Hi James,

I agree with you - I also cannot say whether these patches have further
implications on the code. So just let it out of the release (or include
it as separate files). It may be included in a next release, when its
more widely tested.

The unit tests were all I was able to test additionally to my "normal
working environment".

When it's a question of excluding the patch or holding up release - then
please exclude it. The release certainly is more important.

Greets,
-Alex