FreeTDS Development Group

["ZIGLIO Frediano" <Frediano.Ziglio AT vodafone.com>]

> > 
> > Anyone can apply my patch ?
> > Mainly it add support for single-byte column conversions.
> > exceptions:
> > - numeric.c   remove printf
> > - odbc.c      applied update patch from ML
> 
> Freddy, I don't understand this change:
> 
> -       TDSICONVINFO *iconv_info;
> +       TDSICONVINFO **iconv_info;
> 
> I like an array of structures better than an array of 
> pointers.  I couldn't find anywhere in the code where the 
> second level of indirection made something possible/easier.  
> Can you show me where that's the case?  
> 
> I know you're concerned about invalidating references to 
> elements in the iconv_info array when it's reallocated, but 
> I'm quite sure that can be avoided without making the data 
> structure more complex.  
> 

Well... as stated TDSCOLINFO->iconv_info point to a
TDSSOCKET->iconv_info[n]. If TDSSOCKET->iconv_info get relocated (when
iconv stuff need to add a new conversion for a different column
encoding) TDSSOCKET->iconv_info[n] can change address so we should scan
all rows/compute/params infos and replace the pointer. Using
TDSICONVINFO** I avoid realloc-ation and I keep TDSICONVINFO data fixed
in memory.

freddy77