FreeTDS Development Group

["James K. Lowden" <jklowden AT schemamania.org>]

Investigating what seems like a silly warning[1] in read.c, I came across
this comment:

if (-1 == tds_iconv(tds, tds->iconv_info, to_client, 
        &ptemp, &templeft, outbuf, outbytesleft)) {
        /* FIXME do not use errno, thread problems */
        if (errno != EINVAL)
                break;
}

AFAIK, there's no fix.  GNU iconv at least is documented as returning
information through errno.  On some multithreaded platforms, errno is
actually a macro to a function call (which prevents assignment, but allows
typical use).  

I think the above code is right, and the comment is not.  If there is an
accepted alternative, would someone please point the way?  Else I'm going
to remove the comment.  

--jkl

1.  "src/tds/read.c:613: warning: statement with no effect"
I think the compiler doesn't notice that outbytesleft may be modified by
tds_iconv().