FreeTDS Development Group

["Castellano, Nicholas" <Nicholas_Castellano AT acml.com>]

It's not really an issue, since all possible return values from
tds_process_results() are accounted for.  So, a default case for the switch
"can't happen".  But in general I agree with you, having a default case is
always good programming practice.  I will add it.

Cheers,
--nick

-----Original Message-----
From: bounce-freetds-145195 AT franklin.oit.unc.edu
[mailto:bounce-freetds-145195 AT franklin.oit.unc.edu] 
Sent: Wednesday, October 30, 2002 11:08 AM
To: TDS Development Group
Subject: [freetds] Question on ct.c


TDS Group:
In the ctlib/ct.c source, method ct_results(), there are two switch
statements in here. The inner one has a default: case, but the outer one
does not.  Is this an issue?  I would think that the outer default case be
the same as TDS_FAIL?

BTW, I cleaned up the tabs here ;-)

                 default:
                      retcode = CS_SUCCEED;
                      *result_type = res_type;
                      done = 1;
                      break;
              }
              break;
         case TDS_NO_MORE_RESULTS:
              done    = 1;
              retcode = CS_END_RESULTS;
              break;
         case TDS_FAIL:
              done    = 1;
              retcode = CS_FAIL;
              break;
         }
   }
   return (retcode);
}

---
You are currently subscribed to freetds as: [Nicholas_Castellano AT acml.com]
To unsubscribe, forward this message to
$subst('Email.Unsub')


The information contained in this transmission may contain privileged and
confidential information and is intended only for the use of the person(s)
named above.  If you are not the intended recipient, or an employee or agent
responsible for delivering this message to the intended recipient, any
review, dissemination, distribution or duplication of this communication is
strictly prohibited. If you are not the intended recipient, please contact
the sender immediately by reply e-mail and destroy all copies of the
original message. Please note that we do not accept account orders and/or
instructions by e-mail, and therefore will not be responsible for carrying
out such orders and/or instructions.