FreeTDS Development Group

["Castellano, Nicholas" <Nicholas_Castellano AT acml.com>]

Two comments from the peanut gallery:

- Why not just add the flags to the CS_CONTEXT directly?  From an
application, CS_CONTEXT is opaque, so it shouldn't matter too much if it is
changed.

- I've already touched this section of the code.  Any chance you could
update from CVS before making your changes?  Otherwise, merging your stuff
in is going to be painful.

Cheers,
--nick

-----Original Message-----
From: bounce-freetds-145195 AT franklin.oit.unc.edu
[mailto:bounce-freetds-145195 AT franklin.oit.unc.edu] 
Sent: Friday, September 27, 2002 9:25 AM
To: TDS Development Group
Subject: [freetds] Re: One for Brian, I think...


>From first blush it looks like the right and proper thing to do.  You have
my blessing (like you need it!).

Brian

> ...although please feel free to chip in if you have a view...
> 
> I'm wanting to implement some of the ct-library option flags that can 
> be manipulated with ct_config(), a function that is currently 
> unimplemented.
> 
> In order to do this, I'm going to need somewhere to store them. I 
> thought I'd ask your opinion, as I'm not *really* an expert in the 
> ct-library code.
> 
> ct_config() is defined as follows:
> 
> CS_RETCODE ct_config(CS_CONTEXT *ctx, CS_INT action, CS_INT property, 
> CS_VOID *buffer, CS_INT buflen, CS_INT *outlen)
> 
> given this, it seemd logical to me to store these flags somewhere in 
> the CS_CONTEXT structure. This is currenty defined as follows:
> 
> typedef struct cs_context
> {
>     CS_INT date_convert_fmt;
>     int (*_clientmsg_cb)(void*, void*, void*);
>     int (*_servermsg_cb)(void*, void*, void*);
>     TDSCONTEXT *tds_ctx;
> } CS_CONTEXT;
> 
> As these flags are for ct-library only. It made sense to me to store 
> them in the CS_CONTEXT structure itself, rather than the TDSCONTEXT 
> structure therein.
> 
> So, what I propose to do is as follows:
> 
> typedef struct cs_config
> {
>     short cs_expose_formats;
> } CS_CONFIG;
> 
> typedef struct cs_context
> {
>     CS_INT date_convert_fmt;
>     int (*_clientmsg_cb)(void*, void*, void*);
>     int (*_servermsg_cb)(void*, void*, void*);
>     TDSCONTEXT *tds_ctx;
>     CS_CONFIG config;
> } CS_CONTEXT;
> 
> where "cs_expose_formats" is the particular flag I am interested in 
> implementing at the moment. More would be added to the CS_CONFIG 
> structure as and when we support them.
> 
> I'd like to get your opinion on whether I've done the right thing.
> 
> Bill

---
You are currently subscribed to freetds as: [Nicholas_Castellano AT acml.com]
To unsubscribe, forward this message to
$subst('Email.Unsub')


The information contained in this transmission may contain privileged and
confidential information and is intended only for the use of the person(s)
named above.  If you are not the intended recipient, or an employee or agent
responsible for delivering this message to the intended recipient, any
review, dissemination, distribution or duplication of this communication is
strictly prohibited. If you are not the intended recipient, please contact
the sender immediately by reply e-mail and destroy all copies of the
original message. Please note that for certain accounts we do not accept
orders and/or instructions by e-mail, and for those accounts we will not be
responsible for carrying out such orders and/or instructions. Kindly refrain
from sending orders or instructions by e-mail unless you have confirmed that
we accept such communications for your account. Please also note that to
satisfy regulatory requirements we review the outgoing and incoming e-mail
correspondence of staff members serving certain functions.