Skip to Content.
Sympa Menu

freetds - RE: shared object version numbers

freetds AT lists.ibiblio.org

Subject: FreeTDS Development Group

List archive

Chronological Thread  
  • From: "Castellano, Nicholas" <Nicholas_Castellano AT acml.com>
  • To: "'TDS Development Group'" <freetds AT franklin.metalab.unc.edu>
  • Subject: RE: shared object version numbers
  • Date: Tue, 24 Sep 2002 10:24:38 -0400


The function was removed because it was getting in my way :-)

Seriously, it doesn't serve any useful purpose, and it was stomping on data
that I needed. In src/tds/token.c:tds_process_msg(), notice that
tds->msg_info->msg_number is accessed after the msg_handler has already been
called. If our calling conventions require that the msg_handler zero this
information, msg_number would always be gone by that point.

It seemed silly to require that the calling function do this cleanup, when
the caller will eventually call tds_free_msg(tds->msg_info) which (with a
little tweaking) now does everything that tds_reset_msg_info() did before.

I don't see any place in the code that requires a distinction between the
functionality of tds_reset_msg_info() and tds_free_msg(). Why retain an
awkward and unnecessary interface?

I don't know why there's a msg_info field in TDSSOCKET, so I just left that
part alone.

Cheers,
--nick

-----Original Message-----
From: bounce-freetds-145195 AT franklin.oit.unc.edu
[mailto:bounce-freetds-145195 AT franklin.oit.unc.edu]
Sent: Tuesday, September 24, 2002 10:04 AM
To: TDS Development Group
Subject: [freetds] RE: shared object version numbers


>
> I removed an interface (tds_reset_msg_info()) from libtds
> yesterday. I was
> going to bump the libtds major version number, but I decided
> to actually go
> read the libtool docs first. They strongly suggest bumping
> up the library
> version information only immediately before a release. So,
> I'm going to
> leave it alone. Jim, perhaps bumping up the version numbers
> appropriately
> should be added to doc/README.releasing?
>

I don't understand the reason to remove this function...
Also I don't understand the reason to have a msg_info field in TDSSOCKET. I
think this use should be reviewed, seem to me old stuff only...

freddy77

=================================
"STRICTLY PERSONAL AND CONFIDENTIAL

This message may contain confidential and proprietary material for the sole
use of the intended recipient. Any review or distribution by others is
strictly prohibited. If you are not the intended recipient please contact
the sender and delete all copies.
The contents of this message that do not relate to the official business of
our company shall be understood as neither given nor endorsed by it."

=================================

---
You are currently subscribed to freetds as: [Nicholas_Castellano AT acml.com]
To unsubscribe, forward this message to
$subst('Email.Unsub')


The information contained in this transmission may contain privileged and
confidential information and is intended only for the use of the person(s)
named above. If you are not the intended recipient, or an employee or agent
responsible for delivering this message to the intended recipient, any
review, dissemination, distribution or duplication of this communication is
strictly prohibited. If you are not the intended recipient, please contact
the sender immediately by reply e-mail and destroy all copies of the
original message. Please note that for certain accounts we do not accept
orders and/or instructions by e-mail, and for those accounts we will not be
responsible for carrying out such orders and/or instructions. Kindly refrain
from sending orders or instructions by e-mail unless you have confirmed that
we accept such communications for your account. Please also note that to
satisfy regulatory requirements we review the outgoing and incoming e-mail
correspondence of staff members serving certain functions.






Archive powered by MHonArc 2.6.24.

Top of Page