FreeTDS Development Group

["Castellano, Nicholas" <Nicholas_Castellano AT acml.com>]

I have posted a complete patch on sourceforge, so that you can see the full
context of this change.

--nick

-----Original Message-----
From: Castellano, Nicholas 
Sent: Thursday, September 12, 2002 10:35 AM
To: 'TDS Development Group'
Subject: RE: [freetds] Re: WARNING: Changing tds_connect() API


My original thoughts were along these lines...but as I looked further, I
realized that tds_connect() really needs to be able to change the state at
different points depending on various conditions.  The TDSSOCKET shouldn't
appear live until after the connect() call, and if the login fails it should
appear dead when the "Login incorrect." message is sent.  So breaking up the
calls in the ways that you suggest really don't provide the degree of
control that I think is needed.

Here's an excerpt from my version, showing the critical sections where the
state needs to change.  Note that the two calls to tds_client_msg() shown
below need the state to be dead, while any calls to tds_client_msg()
performed from tds_process_login_tokens() need the state to be live:


The information contained in this transmission may contain privileged and
confidential information and is intended only for the use of the person(s)
named above.  If you are not the intended recipient, or an employee or agent
responsible for delivering this message to the intended recipient, any
review, dissemination, distribution or duplication of this communication is
strictly prohibited. If you are not the intended recipient, please contact
the sender immediately by reply e-mail and destroy all copies of the
original message. Please note that for certain accounts we do not accept
orders and/or instructions by e-mail, and for those accounts we will not be
responsible for carrying out such orders and/or instructions. Kindly refrain
from sending orders or instructions by e-mail unless you have confirmed that
we accept such communications for your account. Please also note that to
satisfy regulatory requirements we review the outgoing and incoming e-mail
correspondence of staff members serving certain functions.