FreeTDS Development Group

["Castellano, Nicholas" <Nicholas_Castellano AT acml.com>]

I will be changing the API for tds_connect().  Currently, this function
returns the TDSSOCKET * to its caller.  However, in dblib we need this
information in the dbproc before tds_connect() returns.  When error or
message handlers are invoked during login, the dbproc currently appears to
be DBDEAD() since the socket is not set up. In the new scheme, tds_connect
will take a TDSSOCKET ** parameter, and will fill in the new TDSSOCKET **
when it has been connected to the database server.

So instead of:

dbproc->tds_socket = (void *) tds_connect(login->tds_login,
g_dblib_ctx->tds_ctx, (void *)dbproc);

We will now have:

tds_connect(&(dbproc->tds_socket), login->tds_login, g_dblib_ctx->tds_ctx,
(void *)dbproc);

Of course all the other calls throughout the tree will be updated as well,
to use the new API.

I intend to commit this early tomorrow (along with a while bunch of other
error/message handler fixes), unless there are any serious objections.

Cheers,
--nick



The information contained in this transmission may contain privileged and
confidential information and is intended only for the use of the person(s)
named above.  If you are not the intended recipient, or an employee or agent
responsible for delivering this message to the intended recipient, any
review, dissemination, distribution or duplication of this communication is
strictly prohibited. If you are not the intended recipient, please contact
the sender immediately by reply e-mail and destroy all copies of the
original message. Please note that for certain accounts we do not accept
orders and/or instructions by e-mail, and for those accounts we will not be
responsible for carrying out such orders and/or instructions. Kindly refrain
from sending orders or instructions by e-mail unless you have confirmed that
we accept such communications for your account. Please also note that to
satisfy regulatory requirements we review the outgoing and incoming e-mail
correspondence of staff members serving certain functions.