FreeTDS Development Group

["Lowden, James K" <LowdenJK AT bernstein.com>]

> From: Castellano, Nicholas [mailto:Nicholas_Castellano AT acml.com]
> Sent: August 22, 2002 10:26 AM
> 
> That'll teach me to send untested patches...OK...maybe not...here's an
> updated patch, this one actually stands a chance of being right.


What's one little inky dinky "v" among friends?  

You're absolutely right.  Can't update cvs from here.  Will do when can.
Thanks.  

--jkl

> 
> Index: dblib.c
> ===================================================================
> RCS file: /cvsroot/freetds/freetds/src/dblib/dblib.c,v
> retrieving revision 1.36
> diff -u -r1.36 dblib.c
> --- dblib.c   22 Aug 2002 03:41:57 -0000      1.36
> +++ dblib.c   22 Aug 2002 14:25:35 -0000
> @@ -35,7 +35,7 @@
>                                       no_unused_var_warn};
>  
>  #if  !HAVE_VASPRINTF
> -extern int asprintf(char **ret, const char *fmt, va_list ap);
> +extern int vasprintf(char **ret, const char *fmt, va_list ap);
>  #endif
>  
>  static int _db_get_server_type(int bindtype);
> 
> -----Original Message-----
> From: bounce-freetds-145195 AT franklin.oit.unc.edu
> [mailto:bounce-freetds-145195 AT franklin.oit.unc.edu] 
> Sent: Thursday, August 22, 2002 10:12 AM
> To: TDS Development Group
> Subject: [freetds] Re: patch: dblib.c without vsnprintf
> 
> 
> Hmmm...in dblib.c, you're providing a prototype for 
> asprintf(), but you're
> actually using the vasprintf() interface.  Seems to me that 
> you should be
> providing a prototype for vasprintf().  Here's a patch 
> (untested, sorry...)
> 
> [Incorrect patch removed]
> 
> -----Original Message-----
> From: bounce-freetds-145195 AT franklin.oit.unc.edu
> [mailto:bounce-freetds-145195 AT franklin.oit.unc.edu] 
> Sent: Thursday, August 22, 2002 2:08 AM
> To: TDS Development Group
> Subject: [freetds] Re: patch: dblib.c without vsnprintf
> 
> 
> On Thu, 22 Aug 2002 13:26:01 +0800, "Varley, David(CBorn at Alcoa)"
> <David.Varley AT alcoa.com.au> wrote:
> 
> > I just overwrote my changes with your correct ones,
> > only problem is that vasprintf() is only included in libtds.so, not
> > libsybdb.so where it is needed! I patched my Makefile to 
> include it, 
> > and it works and only fails 1 of 19 tests.
> > 
> > I guess the proper place to add asprintf.lo is in a Makefile.in (or
> > .am?), if you can do that we'll be cooking with gas :)
> 
> Thanks, David!
> 
> src/dblib/Makefile.am, you're quite right.  Committed in cvs 
> moments ago. 
> 
> 
> It's quite late here.  If it's broken, take two asprin and 
> call me in the
> morning.  ;)
> 
> Regards, 
> 
> --jkl
> 


The information contained in this transmission may contain privileged and
confidential information and is intended only for the use of the person(s)
named above.  If you are not the intended recipient, or an employee or agent
responsible for delivering this message to the intended recipient, any
review, dissemination, distribution or duplication of this communication is
strictly prohibited. If you are not the intended recipient, please contact
the sender immediately by reply e-mail and destroy all copies of the
original message. Please note that for certain accounts we do not accept
orders and/or instructions by e-mail, and for those accounts we will not be
responsible for carrying out such orders and/or instructions. Kindly refrain
from sending orders or instructions by e-mail unless you have confirmed that
we accept such communications for your account. Please also note that to
satisfy regulatory requirements we review the outgoing and incoming e-mail
correspondence of staff members serving certain functions.