FreeTDS Development Group

["Brian Bruns" <camber AT ais.org>]

It think the root cause may be deeper.  Why is a short destlen being asked
for?  This may have something to do with the return value of dbdatlen() or
similar calls... ie the application code may be:

mylen = dbdatlen(dbproc, colnum);
mybuf = malloc(mylen);
dbconvert(dbproc,..., mybuf, mylen);

So by fixing dbdatlen() or whichever it turns out to be, we may get an
extra char *and* no buffer problem.

Brian

> I think you're right, Frediano; the code is still broken.  
> 
> We shouldn't null-terminate unless destlen is -1.  If the destination buffer
> is too small, we should call the error handler and return -1.  So say the
> docs.  Eric?  
> 
> --jkl