XOM API for Processing XML with Java

["Steve Loughran" <steve.loughran AT gmail.com>]

On 31/10/06, Ed Davies <edavies AT nildram.co.uk> wrote:
> Steve Loughran wrote:
> > ...
> > I make my iterators implement iterable instead:
> > public Iterator<Node> iterator() {
> >         return this;
> >     }
> > ...
>
> Clever way to save garbage collection of a separate Iterable
> object, but shouldn't an Iterable return a new Iterator each
> time iterator() is called?


That's precisely why I think what I am doing consistutes an abuse. :)

> I realise that's not likely to happen in your common usage
> pattern but, still, wouldn't it be safer to at least throw an
> exception if iterator() is called twice?  That wouldn't guard
> against a direct cast from Iterable to Iterator, of course,
> but that would be cheating.

Good point. I could store a reference to myself in the constructor,
return that the first time and set it to null. Second time round:NPE.