sm-sorcery AT lists.ibiblio.org
Subject: Discussion of Sorcery related topics
List archive
[SM-Sorcery] bug #2777 present in sorcery 1.0.1, we need a 1.0.2
- From: Arwed von Merkatz <v.merkatz AT gmx.net>
- To: sm-sorcery AT lists.ibiblio.org
- Subject: [SM-Sorcery] bug #2777 present in sorcery 1.0.1, we need a 1.0.2
- Date: Sun, 23 Mar 2003 00:51:07 +0100
Hi,
bug #2777 is present in sorcery 1.0.1, this is a really _critical_ bug
that may cause random failures of spells (i'm pretty sure bug #2794 is
caused by this).
Devel sorcery doesn't have it anymore, i think there should be a sorcery
stable 1.0.2 release asap
--
Arwed v. Merkatz
Grimoire Guru for video
Sourcemage GNU/Linux
http://www.sourcemage.org
>From sergey AT optimaltec.com Mon Mar 31 11:45:12 2003
Return-Path: <sergey AT optimaltec.com>
Delivered-To: sm-sorcery AT lists.ibiblio.org
Received: from dev.naniny.com (66-95-149-132.generic.nas-inter.net
[66.95.149.132]) by happyhouse.metalab.unc.edu (Postfix) with
ESMTP
id 1C1AF2001A; Mon, 31 Mar 2003 11:45:11 -0500 (EST)
Received: from optimaltec.com (localhost [127.0.0.1])
by dev.naniny.com (Postfix) with ESMTP
id 04400BBF29; Mon, 31 Mar 2003 11:45:09 -0500 (EST)
Message-ID: <3E887095.7040708 AT optimaltec.com>
Date: Mon, 31 Mar 2003 11:45:09 -0500
From: "Sergey A. Lipnevich" <sergey AT optimaltec.com>
User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: sm-sorcery AT lists.ibiblio.org, sm-grimoire AT lists.ibiblio.org
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [SM-Sorcery] [PATCH] Preserve OPTS set by $SPELL_CONFIG
X-BeenThere: sm-sorcery AT lists.ibiblio.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion of Sorcery related topics <sm-sorcery.lists.ibiblio.org>
List-Unsubscribe: <http://lists.ibiblio.org/mailman/listinfo/sm-sorcery>,
<mailto:sm-sorcery-request AT lists.ibiblio.org?subject=unsubscribe>
List-Archive: <https://lists.ibiblio.org/sympa/arc/sm-sorcery>
List-Post: <mailto:sm-sorcery AT lists.ibiblio.org>
List-Help: <mailto:sympa AT lists.ibiblio.org?subject=HELP>
List-Subscribe: <http://lists.ibiblio.org/mailman/listinfo/sm-sorcery>,
<mailto:sm-sorcery-request AT lists.ibiblio.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Mar 2003 16:45:12 -0000
Hi All,
There are a number of spells in the grimoire that set OPTS in the
$SPELL_CONFIG file. Because $SPELL_CONFIG is run only once before
libdepends::satisfy_depends(), where OPTS is reset, all such spells are
not configured properly (configuration options setting OPTS directly are
effectively lost). I intend to apply the following patch to fix
satisfy_depends to preserve whatever OPTS have been accumulated from the
run_spell_config() call, the patch is attached. Any objections?
Thanks!
Sergey.
==== //sgl/devel/sorcery/var/lib/sorcery/modules/libdepends#5 -
/home/sergey/smgl-p4/devel/sorcery/var/lib/sorcery/modules/libdepends ====
@@ -100,7 +100,7 @@
debug "libdepends" "run_spell_config() -
DEPENDS_CONFIG=$DEPENDS_CONFIG SPELL=$SPELL, SPELL_C
ONFIG=$SPELL_CONFIG DEPENDS_STATUS=$DEPENDS_STATUS"
if [ -x $SPELL_CONFIG ]; then
- debug "libdepends" "satisfy_depends() - found $SPELL_CONFIG"
+ debug "libdepends" "run_spell_config() - found $SPELL_CONFIG"
. $SPELL_CONFIG
fi
@@ -139,7 +139,9 @@
debug "libdepends" "Running satisfy_depends() on $SPELL"
local DEP
- unset OPTS
+ unset OPTS
+
+ # some spells apply changes to OPTS directly
run_spell_config
local LINE=''
@@ -195,7 +197,8 @@
# TODO: Do something about exiled spells so that they've got `off'
# in DEPENDS_STATUS file, or something else do improve this
#
- OPTS=`get_depends_options "$SPELL"`
+ local OPTS_DEPENDS=$(get_depends_options "$SPELL")
+ OPTS="$OPTS $OPTS_DEPENDS"
debug 'libdepends' "satisfy_depends() - final OPTS=$OPTS"
}
- [SM-Sorcery] bug #2777 present in sorcery 1.0.1, we need a 1.0.2, Arwed von Merkatz, 03/22/2003
Archive powered by MHonArc 2.6.24.