sm-sorcery AT lists.ibiblio.org
Subject: Discussion of Sorcery related topics
List archive
- From: Dufflebunk <dufflebunk AT dufflebunk.homeip.net>
- To: Aaron Brice <abrice2 AT cox.net>
- Cc: peter AT schneider-kamp.de, sm-sorcery AT lists.ibiblio.org
- Subject: Re: [SM-Sorcery]new option CLEAN_SOURCE
- Date: Sat, 31 Aug 2002 17:17:46 -0400
I think leaving it with an always or never choice is good. You can always
turn it on manualy before a rebuild if that's how you want it. I see no need
to add another option.
On 31 Aug 2002 14:06:13 -0700
Aaron Brice <abrice2 AT cox.net> wrote:
> This is good. One modification I would suggest is that I'd like to
> clean the source during a sorcery rebuild or cast --fix but not during a
> normal cast
>
> I'll submit a patch, but what would be the best way to do this? My
> opinion is it would be best to just have sorcery rebuild set
> CLEAN_SOURCE whenever a rebuild is started. Is there anyone that wants
> to keep these directories during a sorcery rebuild? Seems dangerous,
> and you can just go check the logs after the rebuild and re-cast any
> failed spells.
>
> Or, another option, REBUILD_CLEAN could be added, and if $CLEAN_SOURCE
> == "off" and $REBUILD_CLEAN == "on" then a sorcery rebuild would set
> CLEAN_SOURCE = "on". It seems to me though that keeping the source
> during a rebuild is not useful and causes problems, and I don't want to
> eventually have 20 pages of sorcery options...
>
> Aaron
>
>
> On Sat, 2002-08-31 at 07:26, Peter Schneider-Kamp wrote:
> > This patch introduces a new option CLEAN_SOURCE.
> >
> > If CLEAN_SOURCE is on, rm_source_dir() is also called
> > when the build fails.
> >
> > Greetz
> > Peter
> > --
> > Peter Schneider-Kamp mailto:peter AT schneider-kamp.de
> > Deliusstrasse 9 http://schneider-kamp.de
> > D-52064 Aachen mobile phone: ++49 178 495 1040
> > ----
> >
>
> > Index: etc/sorcery/config
> > ===================================================================
> > RCS file: /cvsroot/sourcemage/sourcemage/sorcery/etc/sorcery/config,v
> > retrieving revision 1.35
> > diff -c -r1.35 config
> > *** etc/sorcery/config 2002/08/30 03:09:53 1.35
> > --- etc/sorcery/config 2002/08/31 14:25:35
> > ***************
> > *** 81,86 ****
> > --- 81,87 ----
> > MAX_CABALS=${MAX_CABALS:=16}
> > NET_SELECT=${NET_SELECT:=off}
> > MD5SUM_DL=${MD5SUM_DL:=off}
> > + CLEAN_SOURCE=${CLEAN_SOURCE:=off}
> >
> > LDD_CHECK=${LDD_CHECK:=on}
> > FIND_CHECK=${FIND_CHECK:=on}
> > Index: usr/sbin/cast
> > ===================================================================
> > RCS file: /cvsroot/sourcemage/sourcemage/sorcery/usr/sbin/cast,v
> > retrieving revision 1.23
> > diff -c -r1.23 cast
> > *** usr/sbin/cast 2002/08/26 01:57:32 1.23
> > --- usr/sbin/cast 2002/08/31 14:25:37
> > ***************
> > *** 271,277 ****
> > message "${PROBLEM_COLOR}" \
> > "! Problem Detected !" \
> > "${DEFAULT_COLOR}"
> > - rm -f $CASTING
> > view_compile_log
> > rack
> > false
> > --- 255,260 ----
> > ***************
> > *** 928,934 ****
> > report_install &&
> > rm -f $CASTING &&
> > sound SUCCESS &&
> > ! activity_log "cast" "$SPELL" "$VERSION" "success"
> > fi
> >
> > ) }
> > --- 911,923 ----
> > report_install &&
> > rm -f $CASTING &&
> > sound SUCCESS &&
> > ! activity_log "cast" "$SPELL" "$VERSION" "success" ||
> > ! {
> > ! rm -f $CASTING
> > ! if [[ $CLEAN_SOURCE == on ]]; then
> > ! rm_source_dir
> > ! fi
> > ! }
> > fi
> >
> > ) }
> > Index: usr/sbin/sorcery
> > ===================================================================
> > RCS file: /cvsroot/sourcemage/sourcemage/sorcery/usr/sbin/sorcery,v
> > retrieving revision 1.50
> > diff -c -r1.50 sorcery
> > *** usr/sbin/sorcery 2002/08/26 19:15:50 1.50
> > --- usr/sbin/sorcery 2002/08/31 14:25:40
> > ***************
> > *** 1052,1057 ****
> > --- 1052,1058 ----
> > V_HELP="View compilation as it happens?"
> > X_HELP="Download and apply xdelta patches when available?"
> > NS_HELP="Use netselect to try fastest mirrors first if netselect is
> > available?"
> > + CS_HELP="Clean up source directories after failures?"
> >
> > ARCHIVE=${ARCHIVE:=on}
> > AUTOFIX=${AUTOFIX:=on}
> > ***************
> > *** 1071,1076 ****
> > --- 1072,1078 ----
> > VOYEUR=${VOYEUR:=on}
> > REAP=${REAP:=on}
> > NET_SELECT=${NET_SELECT:=off}
> > + CLEAN_SOURCE=${CLEAN_SOURCE:=off}
> >
> > if TOGGLES=`$DIALOG --title "Feature Menu" \
> > --no-cancel \
> > ***************
> > *** 1096,1104 ****
> > "VIEW_REPORTS" "Toggle" "$VIEW_REPORTS" "$R_HELP" \
> > "VOYEUR" "Toggle" "$VOYEUR" "$V_HELP" \
> > "REAP" "Toggle" "$REAP" "$E_HELP" \
> > ! "NET_SELECT" "Toggle" "$NET_SELECT" "$NS_HELP"`
> > then
> > ! TEMP=(ARCHIVE AUTOFIX AUTOPRUNE CABAL GATHER_DOCS MAIL_REPORTS
> > VIEW_REPORTS PATCH PRESERVE SOUND SUSTAIN TMPFS VOYEUR REAP NET_SELECT
> > CONFIG_LOC)
> > for i in ${TEMP[*]} ; do
> > eval $i=off
> > done
> > --- 1098,1107 ----
> > "VIEW_REPORTS" "Toggle" "$VIEW_REPORTS" "$R_HELP" \
> > "VOYEUR" "Toggle" "$VOYEUR" "$V_HELP" \
> > "REAP" "Toggle" "$REAP" "$E_HELP" \
> > ! "NET_SELECT" "Toggle" "$NET_SELECT" "$NS_HELP" \
> > ! "CLEAN_SOURCE" "Toggle" "$CLEAN_SOURCE" "$CS_HELP"`
> > then
> > ! TEMP=(ARCHIVE AUTOFIX AUTOPRUNE CABAL GATHER_DOCS MAIL_REPORTS
> > VIEW_REPORTS PATCH PRESERVE SOUND SUSTAIN TMPFS VOYEUR REAP NET_SELECT
> > CONFIG_LOC CLEAN_SOURCE)
> > for i in ${TEMP[*]} ; do
> > eval $i=off
> > done
> > ***************
> > *** 1125,1135 ****
> > VOYEUR) VOYEUR=on ;;
> > REAP) REAP=on ;;
> > NET_SELECT) NET_SELECT=on ;;
> > esac
> >
> > done
> >
> > ! TEMP=(ARCHIVE AUTOFIX AUTOPRUNE CABAL GATHER_DOCS MAIL_REPORTS
> > VIEW_REPORTS PATCH PRESERVE SOUND SUSTAIN TMPFS VOYEUR REAP NET_SELECT
> > CONFIG_LOC)
> > for i in ${TEMP[*]} ; do
> > modify_local_config "$i" "${!i}"
> > done
> > --- 1128,1139 ----
> > VOYEUR) VOYEUR=on ;;
> > REAP) REAP=on ;;
> > NET_SELECT) NET_SELECT=on ;;
> > + CLEAN_SOURCE) CLEAN_SOURCE=on ;;
> > esac
> >
> > done
> >
> > ! TEMP=(ARCHIVE AUTOFIX AUTOPRUNE CABAL GATHER_DOCS MAIL_REPORTS
> > VIEW_REPORTS PATCH PRESERVE SOUND SUSTAIN TMPFS VOYEUR REAP NET_SELECT
> > CONFIG_LOC CLEAN_SOURCE)
> > for i in ${TEMP[*]} ; do
> > modify_local_config "$i" "${!i}"
> > done
>
>
> _______________________________________________
> SM-Sorcery mailing list
> SM-Sorcery AT lists.ibiblio.org
> http://lists.ibiblio.org/mailman/listinfo/sm-sorcery
--
Quidquid latine dictum sit, altum sonatur.
-----------------
PGP public key at
http://wwwkeys.ch.pgp.net:11371/pks/lookup?op=get&search=0x92B5D3F1
-
[SM-Sorcery]new option CLEAN_SOURCE,
Peter Schneider-Kamp, 08/31/2002
- Re: [SM-Sorcery]new option CLEAN_SOURCE, Dufflebunk, 08/31/2002
-
Re: [SM-Sorcery]new option CLEAN_SOURCE,
Robin Cook, 08/31/2002
- Re: [SM-Sorcery]new option CLEAN_SOURCE, Peter Schneider-Kamp, 08/31/2002
- Re: [SM-Sorcery]new option CLEAN_SOURCE, Dufflebunk, 08/31/2002
-
Re: [SM-Sorcery]new option CLEAN_SOURCE,
Aaron Brice, 08/31/2002
- Re: [SM-Sorcery]new option CLEAN_SOURCE, Dufflebunk, 08/31/2002
Archive powered by MHonArc 2.6.24.