Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 15237] Sorcery has extra whitespace for some text

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT bugs.sourcemage.org
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 15237] Sorcery has extra whitespace for some text
  • Date: 22 May 2009 08:12:09 -0000

http://bugs.sourcemage.org/show_bug.cgi?id=15237





--- Comment #6 from Eric Sandall <sandalle AT sourcemage.org> 2009-05-22
03:12:09 ---
(In reply to comment #4)
> Why did you remove some of the ending dots from the dependency messages?
> Also
> noticed a ${DEFAULT_COLOR}${MESSAGE_COLOR}, which is not needed.

I mentioned that other "has a(n)" messages (e.g. for suggest depends) didn't
have an ending ".", but mainly because the ending "." was being passed to a
function which included it in the SPELL_COLOR setting as that parameter is the
provider name. If the "." is still wanted the function would need another
parameter for extra messages at the end (e.g. "."), or the function itself
should tack on a "." at the end, after the last parameter.

As for a ${DEFAULT_COLOR}${MESSAGE_COLOR}, you are probably referring to this
portion in libunpack?
- "${DEFAULT_COLOR}${MESSAGE_COLOR}for spell${SPELL_COLOR}" \
- "${SPELL}${DEFAULT_COLOR}${MESSAGE_COLOR}.${DEFAULT_COLOR}"
+
"${SPELL_COLOR}${SPELL}${DEFAULT_COLOR}${MESSAGE_COLOR}.${DEFAULT_COLOR}"
- "${DEFAULT_COLOR}${MESSAGE_COLOR}for spell${SPELL_COLOR}" \
- "${SPELL}${DEFAULT_COLOR}${MESSAGE_COLOR}.${DEFAULT_COLOR}"
+
"${SPELL_COLOR}${SPELL}${DEFAULT_COLOR}${MESSAGE_COLOR}.${DEFAULT_COLOR}"

The DEFAULT_COLOR is to clear the SPELL_COLOR set earlier, as MESSAGE_COLOR
does not clear out all other color modifiers, so in this example the "." would
have SPELL_COLOR+MESSAGE_COLOR rather than just MESSAGE_COLOR.

--
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.




Archive powered by MHonArc 2.6.24.

Top of Page