Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 15234] New: BUILD_DIRECTORY inconsistent; PATCH

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT bugs.sourcemage.org
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 15234] New: BUILD_DIRECTORY inconsistent; PATCH
  • Date: 19 May 2009 09:23:28 -0000

http://bugs.sourcemage.org/show_bug.cgi?id=15234

Summary: BUILD_DIRECTORY inconsistent; PATCH
Product: Sorcery
Version: 1.14.x
Platform: x86
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P3
Component: Unknown
AssignedTo: sm-sorcery-bugs AT lists.ibiblio.org
ReportedBy: eekee57 AT fastmail.fm


Any spell which relies on $SOURCE_DIRECTORY in INSTALL has a problem if
$INSTALL_ROOT is set.

Reason for problem: $SOURCE_DIRECTORY is set in DETAILS as a subdirectory of
$BUILD_DIRECTORY. $BUILD_DIRECTORY is set in /etc/sorcery/config as a subdir
of
$INSTALL_ROOT. Before INSTALL is run /etc/sorcery/config and DETAILS are
sourced with empty $INSTALL_ROOT. This is correct for many variables but not
for $BUILD_DIRECTORY which must remain consistent.

As an example of what can go wrong, zlib INSTALL has as it's first line:

cd $SOURCE_DIRECTORY.static &&

Now, I cast it with INSTALL_ROOT=/trees/baksys and I find zlib compiled where
I'd expect, /trees/baksys/usr/src/zlib-1.2.3.static exists. In INSTALL
$INSTALL_ROOT is unset and $BUILD_DIRECTORY and $SOURCE_DIRECTORY all re-set,
so cd $SOURCE_DIRECTORY.static cannot work. The actual error from cast:

Preparing to install zlib
castfs: checking sanity of <mnt-dir> and <stage-dir>
castfs: stagedir is okay!
/home/ethan/smgl/stable/archive-libs/zlib/INSTALL: line 1: cd:
/usr/src/zlib-1.2.3.static: No such file or directory
INSTALL failed!
! Problem Detected !


While it might be nice to automatically set $BUILD_DIRECTORY differently for
each $INSTALL_ROOT target, the requirement for consistancy and the
unavailability of $INSTALL_ROOT at certain times make this very difficult.
It's
far easier to set $BUILD_DIRECTORY without reference to $INSTALL_ROOT. The
attached patch does this & also adds a warning comment.

--
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.




Archive powered by MHonArc 2.6.24.

Top of Page