Bugs for Sorcery are reported here

[bugzilla-daemon AT bugs.sourcemage.org]

http://bugs.sourcemage.org/show_bug.cgi?id=14620





--- Comment #4 from fredrik.carlstrom AT tele2.se  2008-08-07 12:07:49 ---
(In reply to comment #2)
> The comment changes are wierd - they should be clear enough that our 
> grimoire
gurus don't need to know the function itself to know how to use it.

I've mixed the "@return 0" and "@return 1" comments. Sorry about that. This 
has
been corrected. I've tried to make the description of the new behavior a 
little
more intuitive, but any improvements you can think of are welcome.

> The debug echos don't belong in the finished function.

No they don't! They have been removed.

> It would probably be easier to understand, if you implemented it in awk 
> with the > dot as a field delimiter.

This is a matter of taste. Besides, I think I saw somewhere that the
dependencies should be kept to a minimum in the sorcery.

> like in the previous implementation, the version check is not strict enough 
> -
> checking for 4.3 would also match in 3.4.3.

I haven't changed the original behavior of the function since that would break
existing code, and so that people who think they know how the function works,
wont get any unpleasant surprises. If this behavior is to be changed, it 
should
be implemented in a new function under another name.


-- 
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.