Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 14618] New: cleanse --tablet coalesce is broken

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT bugs.sourcemage.org
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 14618] New: cleanse --tablet coalesce is broken
  • Date: 3 Aug 2008 03:52:57 -0000

http://bugs.sourcemage.org/show_bug.cgi?id=14618

Summary: cleanse --tablet coalesce is broken
Product: Sorcery
Version: 1.14.x
Platform: Other
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Cleanse
AssignedTo: sm-sorcery-bugs AT lists.ibiblio.org
ReportedBy: acedit AT armory.com


change 18a01137dcb6436756085ba2946651d2fcbaa106 breaks tablet coalescing.

The call to iterate with the output of find and a sub-routine was replaced by
piping find into a while loop. However the while loop calls hash_append.
Because this happens in a sub-shell (due to the pipe), the hash table of the
main function body is not updated. As a result the actual coalescing receives
an empty table as does not function as expected.

Other areas of the code which were "iterate" and became pipes should be
inspected for correctness. In general any place iterate appears, its to avoid
executing some code in a subshell. Perhaps I should have commented that
better,
I apologize. Reverting the change should be sufficient to fix this.


--
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.




Archive powered by MHonArc 2.6.24.

Top of Page