Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 13729] url_generic_apifunc ignores url_get_prefix exit status

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT bugs.sourcemage.org
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 13729] url_generic_apifunc ignores url_get_prefix exit status
  • Date: 20 Apr 2007 18:58:02 -0000

http://bugs.sourcemage.org/show_bug.cgi?id=13729





------- Additional Comments From jakakranjc AT email.si 2007-04-20 13:58 -------
non-zero results are always empty and checking for that also catches the
impossible empty zero results. Point taken. :)

Other places where url_get_prefix is used:
2x scribe with CODEX_URL - I think this one can be left alone, we provide a
working default and it is not something users would change.

libsummon::unpack_for_update: this one should get it too, the arguments are
source urls from spells or summon -r

liburl::url_rank_divide_by_prefix: already uses &&
the other one is covered by the initial report

url_default::url_default_crack: already checks for an empty var
url_default_bucketize: this is just a one-line wrapper



So unpack_for_update is left. It already returns 1 in one case, but the only
one caller (download_src_args) disregards the return code, so I think that
should be fixed aswell.


--
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.




Archive powered by MHonArc 2.6.24.

Top of Page