Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 12387] Scribe breaks grimoires if there's not enought disk space

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT bugs.sourcemage.org
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 12387] Scribe breaks grimoires if there's not enought disk space
  • Date: 25 Nov 2006 19:14:49 -0000

http://bugs.sourcemage.org/show_bug.cgi?id=12387


acedit AT armory.com changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED




------- Additional Comments From acedit AT armory.com 2006-11-25 13:14 -------
It looks like the problem lies in scribe::unpackage_grimoire_tarball(). The
function unpacks the tarball. Then checks if the tarball was properly
formatted
by looking for a certain directory name. If it exists the function claims
success. This works by accident for things like corrupt tarballs, because tar
itself fails on invalid input before making the base directory. In the
out-of-space case, theres enough room to make the base directory (sufficient
for
the function to succeed), but not enough to unpack the rest of the grimoire.

The unpackage_grimoire_tarball function claims success. As a result the rest
of
the scribe code (on either add or update paths) proceeds to remove the old
grimoire, remove the new grimoire tarball, reindex the new grimoire, and
present
the new grimoire's changelog.

Added a check for tar failures (out-of-space (ENOSPC) should be handled by
tar,
if not lets report it upstream).

Fixed in devel at 3fd314ae8551875f02a13552ff1e434050856066

--
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.



  • [SM-Sorcery-Bugs] [Bug 12387] Scribe breaks grimoires if there's not enought disk space, bugzilla-daemon, 11/25/2006

Archive powered by MHonArc 2.6.24.

Top of Page