Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 11753] New: sorcery -q shouldn't queue up spells that are being cast

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT bugs.sourcemage.org
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 11753] New: sorcery -q shouldn't queue up spells that are being cast
  • Date: 3 May 2006 23:52:08 -0000

http://bugs.sourcemage.org/show_bug.cgi?id=11753

Summary: sorcery -q shouldn't queue up spells that are being cast
Product: Sorcery
Version: Untargetted future release
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: Sorcery
AssignedTo: sm-sorcery-bugs AT lists.ibiblio.org
ReportedBy: dmlb2000 AT gmail.com


15:40 < dmlb2000> afrayedknot: what do you think about `sorcery -q` trying to
check for a lock on the spell before it throws it into the queue, it wouldn't
hold the lock but simply check to see if it's already
being cast...
15:41 <@afrayedknot> and what exactly would this accomplish?
15:41 < dmlb2000> prevent spells being cast from going into the queue
15:42 <@afrayedknot> well i can see that
15:43 < dmlb2000> okay :) I'll put a bug in for it, may not get to it quite
yet
but eventually
15:44 <@afrayedknot> you havent answered my question
15:45 < dmlb2000> oh I told you what it prevents not what it accomplishes?
15:45 <@afrayedknot> restated your initial statement
15:47 < dmlb2000> Oh, it just seems a better solution is all, if a spell is
being cast it's most-likely going to be updated to what's current so why would
you want it in the queue to be cast again
15:48 <@afrayedknot> well, the queue code is a pretty tight loop, so adding
anything to it makes me nervous
15:49 < dmlb2000> tight loop?
15:49 * afrayedknot stares
15:49 <@afrayedknot> as in, it has to run really fast because it loops several
hundred times
15:49 <@afrayedknot> and the user is watching
15:50 < dmlb2000> Oh right... yeah I can see that
15:50 < dmlb2000> so adding stuff like checking for locks several hundred
times
will make it a much longer wait
15:53 < dmlb2000> and in most cases checking for the lock will fail, so costs
don't out weight the benifits...
15:55 <@afrayedknot> you could check for the lock as the last possible step
15:56 <@afrayedknot> but that still makes me nervous, i dont know how long it
takes to check for a lock
15:56 < dmlb2000> before it goes into the queue since that would only be for a
few spells
15:56 <@afrayedknot> fewer spells
15:56 < dmlb2000> yeah

We'll need a check_lock function that will only check for the lock this should
be called just before the spell is put in the queue so it gets called fewer
times.

Speed will be an issue with this because of wait time for the user.

--
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



  • [SM-Sorcery-Bugs] [Bug 11753] New: sorcery -q shouldn't queue up spells that are being cast, bugzilla-daemon, 05/03/2006

Archive powered by MHonArc 2.6.24.

Top of Page