Bugs for Sorcery are reported here

[bugzilla-daemon AT bugs.sourcemage.org]

http://bugs.sourcemage.org/show_bug.cgi?id=9080





------- Additional Comments From acedit AT armory.com  2006-02-23 15:16 -------
Some initial comments, I havent looked at the gaze code at all.

Please document the one line addition to libdepengine. Maybe Im confused, but 
it
looks like it should be run inside the if cleanse statement, if and only if 
the
trigger is *not* already registered. That to me, seems better than assuming 
the
spell wont get cast just because the cleanse trigger ran, regardless of its 
status.

I'd prefer you use the push and pop_queue functions instead of sed, its easier
to read. If theres a problem with the push and pop_queue functions, we should
fix them.

In cast, it would be better to append and remove from the NOW_CASTING file,
using locks (push/pop_queue does this already). Then theres one less thing to
worry about if/when cast supports parallel building. I also think the
NOW_CASTING and SPELLS_TO_CAST file might fit more logically in libdepengine,
rather than spread out in the stack. Right now theres stuff above 
libdepengine,
below it, and in it, its somewhat confusing. Maybe I think of these files as 
an
interface to libdepengine.

Also, I might be wrong on this, but the code ignores resurrects, spells are 
only
taken off of SPELLS_TO_CAST if they're cast, not resurrected.

The original bug appears to just be for a way to find out how long a cast of a
spell took, not for an estimated time to completion for an in-progress
multi-spell cast. I'd prefer keeping these clearly distinct issues seperated 
as
much as possible.

-- 
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.