Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 9851] New: incomplete parameter parsing in dispel

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT bugs.sourcemage.org
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 9851] New: incomplete parameter parsing in dispel
  • Date: Tue, 27 Sep 2005 08:04:55 -0700 (PDT)

http://bugs.sourcemage.org/show_bug.cgi?id=9851

Summary: incomplete parameter parsing in dispel
Product: Sorcery
Version: 1.13.x
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: Dispel
AssignedTo: acedit AT armory.com
ReportedBy: acedit AT armory.com
CC: sm-sorcery-bugs AT lists.ibiblio.org


Parameter parsing in dispel looks incomplete:
--child) validate_param $2 ORPHAN_DEFAULT
validate_param $2 NONORPHAN_DEFAULT
shift ;;
--orphan) validate_param $2 ORPHAN_DEFAULT
shift ;;
--non-orphan) validate_param $2 NONORPHAN_DEFAULT
shift ;;
--user-deps) ORPHAN_DEFAULT=$ORPHAN_MENU_DEFAULT
NONORPHAN_DEFAULT=$NONORPHAN_MENU_DEFAULT
RECAST_PARENT_DEFAULT=$RECAST_PARENT_MENU_DEFAULT
DISPEL_PARENT_DEFAULT=$DISPEL_PARENT_MENU_DEFAULT
shift 1 ;;
--user-child-deps) ORPHAN_DEFAULT=$ORPHAN_MENU_DEFAULT
NONORPHAN_DEFAULT=$NONORPHAN_MENU_DEFAULT;;
--recast-parent) validate_param $2 RECAST_PARENT_DEFAULT
shift ;;
--dispel-parent) validate_param $2 DISPEL_PARENT_DEFAULT
shift ;;
--user-parent-deps) RECAST_PARENT_DEFAULT=$RECAST_PARENT_MENU_DEFAULT
DISPEL_PARENT_DEFAULT=$DISPEL_PARENT_MENU_DEFAULT ;;

both user-parent-deps and user-child-deps are missing a shift.

Also, they should probably use validate_param just in case someone manually
messes up the values. Lastly the validate_param routine should say whats wrong
then call help().

--
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.



  • [SM-Sorcery-Bugs] [Bug 9851] New: incomplete parameter parsing in dispel, bugzilla-daemon, 09/27/2005

Archive powered by MHonArc 2.6.24.

Top of Page